Skip to content

Conversation

@anenadic
Copy link
Collaborator

@anenadic anenadic commented Feb 3, 2025

Fixes #427

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-428

The following changes were observed in the rendered markdown documents:

 41-code-review.md | 11 +++--------
 md5sum.txt        |  2 +-
 2 files changed, 4 insertions(+), 9 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-02-03 10:41:06 +0000

@anenadic anenadic requested a review from steve-crouch February 3, 2025 10:40
github-actions bot pushed a commit that referenced this pull request Feb 3, 2025
@svenvanderburg svenvanderburg requested review from svenvanderburg and removed request for steve-crouch February 25, 2025 10:48
Copy link
Collaborator

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution @anenadic! Ready to merge IMO

@bielsnohr bielsnohr merged commit e9a017d into main Mar 10, 2025
3 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
Auto-generated via `{sandpaper}`
Source  : e9a017d
Branch  : main
Author  : Matthew <matthew.bluteau@gmail.com>
Time    : 2025-03-10 11:44:36 +0000
Message : Merge pull request #428 from carpentries-incubator/issue-427

Fix un-rendered callout by changing it to a note
github-actions bot pushed a commit that referenced this pull request Mar 10, 2025
Auto-generated via `{sandpaper}`
Source  : 03819b0
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-03-10 11:45:21 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : e9a017d
Branch  : main
Author  : Matthew <matthew.bluteau@gmail.com>
Time    : 2025-03-10 11:44:36 +0000
Message : Merge pull request #428 from carpentries-incubator/issue-427

Fix un-rendered callout by changing it to a note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Callout not rendered within a list

4 participants