Skip to content

Conversation

@knarrff
Copy link
Contributor

@knarrff knarrff commented Mar 1, 2025

Do not state that .gitignore has to be in the project root, because that would be false. However, state that this is a common location.

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

Copy link
Collaborator

@steve-crouch steve-crouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, well spotted, thanks again @knarrff!

@steve-crouch steve-crouch merged commit 9c42b8d into carpentries-incubator:main Apr 1, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
Auto-generated via `{sandpaper}`
Source  : 9c42b8d
Branch  : main
Author  : Steve Crouch <s.crouch@software.ac.uk>
Time    : 2025-04-01 09:38:33 +0000
Message : Merge pull request #441 from knarrff/gitignore_not_only_project_root

14-collaboration-using-git.md: .gitignore not only project root
github-actions bot pushed a commit that referenced this pull request Apr 1, 2025
Auto-generated via `{sandpaper}`
Source  : 57adb72
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2025-04-01 09:39:25 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 9c42b8d
Branch  : main
Author  : Steve Crouch <s.crouch@software.ac.uk>
Time    : 2025-04-01 09:38:33 +0000
Message : Merge pull request #441 from knarrff/gitignore_not_only_project_root

14-collaboration-using-git.md: .gitignore not only project root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants