Fix compatibility with ZMK PR #3145 and #3140#21
Open
mike1808 wants to merge 3 commits intocarrefinho:feat/new-status-screensfrom
Open
Fix compatibility with ZMK PR #3145 and #3140#21mike1808 wants to merge 3 commits intocarrefinho:feat/new-status-screensfrom
mike1808 wants to merge 3 commits intocarrefinho:feat/new-status-screensfrom
Conversation
Add support for xiao_ble//zmk board variant and update endpoint API calls. Changes: - Add xiao_ble_zmk.overlay for ZMK board variant support (PR #3145) - Replace zmk_endpoints_selected() with zmk_endpoint_get_selected() (PR #3140) Fixes carrefinho#20 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add note about ZMK HWMv2 board variant requirement for proper Bluetooth support. Related to carrefinho#20 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix compatibility with ZMK PR #3145 and #3140
Fixes #20
Summary
This PR updates the prospector-zmk-module to be compatible with recent changes in ZMK's main branch:
Problem
After ZMK PR #3145 was merged, building the dongle (and other keyboards using
xiao_blewith prospector_adapter) failed with:Additionally, ZMK PR #3140 renamed the endpoint API from
zmk_endpoints_selected()tozmk_endpoint_get_selected(), causing compilation errors in the status screen output code.Root Cause
PR #3145: ZMK now uses board variants (e.g.,
xiao_ble//zmk) for ZMK-specific configurations. The vanillaxiao_bleboard no longer includes Bluetooth support by default, which meantCONFIG_ZMK_SPLIT_BLEwas not enabled, leavingZMK_SPLIT_BLE_PERIPHERAL_COUNTundefined.PR #3140: The endpoint selection API was renamed as part of API cleanup.
Changes
Code Changes
Rename
xiao_ble_zmk.overlay(boards/shields/prospector_adapter/boards/xiao_ble_zmk.overlay)Update endpoint API calls (all
src/layouts/*/output.cfiles)zmk_endpoints_selected()withzmk_endpoint_get_selected()Documentation Changes
board: xiao_bletoboard: xiao_ble//zmkTesting
xiao_ble//zmkboard variantMigration Guide
Users need to update their
build.yaml:Before:
After:
Compatibility
xiao_ble//zmkboard variantRelated