Fixed gulp-util vulnerabilities by replacing as suggested in #36#37
Open
Floix wants to merge 4 commits intocarsdotcom:masterfrom
Open
Fixed gulp-util vulnerabilities by replacing as suggested in #36#37Floix wants to merge 4 commits intocarsdotcom:masterfrom
Floix wants to merge 4 commits intocarsdotcom:masterfrom
Conversation
|
Is there any expectation as to when this PR will be merged? |
index.js
Outdated
| var fs = require("fs"), | ||
| path = require("path"), | ||
| through = require("through2"), | ||
| gutil = require("fancy-log"), |
There was a problem hiding this comment.
I don't think this is correct. From the docs on fancy-log, there is no log method attached; rather, the main export is the log function:
https://github.com/gulpjs/fancy-log/blob/master/index.js#L88-L92
So maybe you could make this:
log = require("fancy-log")...and replace all the gutil.log(...) calls with log(...).
Author
There was a problem hiding this comment.
Fixed this with bf34a1d. Thank you for the suggestion
DullReferenceException
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed gulp-util vulnerabilities by replacing as suggested in #36
#36