Fix URL encoding mismatch#84
Merged
carsonyl merged 2 commits intocarsonyl:masterfrom Oct 11, 2025
l4u23n7p:fix/url_encoding_mismatch
Merged
Fix URL encoding mismatch#84carsonyl merged 2 commits intocarsonyl:masterfrom l4u23n7p:fix/url_encoding_mismatch
carsonyl merged 2 commits intocarsonyl:masterfrom
l4u23n7p:fix/url_encoding_mismatch
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @carsonyl ,
Thanks for your work on this project, it has been really helpful in corporate environment.
I opened this PR to fix a bug in proxy authentication URL encoding.
PyPac uses
quote_plusfor encoding whereas requests usesunquotefor decoding.pypac/pypac/resolver.py
Lines 130 to 132 in 44fd400
https://github.com/psf/requests/blob/420d16bc7ef326f7b65f90e4644adc0f6a0e1d44/src/requests/utils.py#L1017.
It leads to space (
) character not being decoded correctly on requests side, resulting in 407 proxy error.I would highly appreciate this fix to be merged.
Regards,