Skip to content

Correctly detect AutoConfigURL on managed Windows systems #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbourguignon-enertrag wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Correctly detect AutoConfigURL on managed Windows systems #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3337a1c
Correctly detect AutoConfigUrl on managed systems
pbourguignon-enertrag Feb 28, 2026
099f7d7
Fix typo in previous changes
pbourguignon-enertrag Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pypac/os_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@ def autoconfig_url_from_registry():
winreg.HKEY_CURRENT_USER, "Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings"
) as key:
return winreg.QueryValueEx(key, "AutoConfigURL")[0]
except WindowsError:
pass # Key or value not found.

try:
with winreg.OpenKey(
winreg.HKEY_LOCAL_MACHINE, "SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Internet Settings"
) as key:
return winreg.QueryValueEx(key, "AutoConfigURL")[0]
except WindowsError:
return # Key or value not found.

Expand Down Expand Up @@ -108,3 +116,5 @@ def __init__(self):
class NotDarwinError(Exception):
def __init__(self):
super(NotDarwinError, self).__init__("Platform is not macOS/OSX.")


Loading