Skip to content

#234 Upgrade Vitest libraries to latest version #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nevendyulgerov merged 13 commits into from
Sep 5, 2024
Merged

#234 Upgrade Vitest libraries to latest version #235

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d1bae4f
chore: Upgrade vitest libraries to latest version
nevendyulgerov Aug 26, 2024
547961e
fix: Fix ts error and set fixed version for actions/setup-node
nevendyulgerov Aug 26, 2024
45b4427
feat(apps/web): Exclude additional folders and files for the coverage…
nevendyulgerov Aug 26, 2024
f942cc0
feat(apps/web): Exclude additional folders and files for the coverage…
nevendyulgerov Aug 26, 2024
e69d5f5
fixup! feat(apps/web): Exclude additional folders and files for the c…
nevendyulgerov Aug 28, 2024
2dc7453
fixup! feat(apps/web): Exclude additional folders and files for the c…
nevendyulgerov Aug 28, 2024
acbf30f
chore: Update yarn.lock
nevendyulgerov Aug 30, 2024
acb984d
test(apps/web): Fix failing tests
nevendyulgerov Sep 2, 2024
c4a3421
feat: Add @vitest/ui package and yarn script
nevendyulgerov Sep 2, 2024
47ac36d
feat: Use istanbul for coverage reporter
nevendyulgerov Sep 4, 2024
e06ed12
fixup! feat: Use istanbul for coverage reporter
nevendyulgerov Sep 4, 2024
b217ac2
feat: Revert back to v8 for coverage reporter
nevendyulgerov Sep 4, 2024
51f3048
feat: Apply ignoreEmptyLines setting for vitest coverage
nevendyulgerov Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions apps/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"lint": "next lint",
"test": "vitest run",
"test:watch": "vitest",
"test:ui": "vitest --ui",
"test:ci": "vitest run --coverage",
"test:e2e": "playwright test",
"test:e2e:ui": "playwright test --ui"
Expand Down Expand Up @@ -64,25 +65,27 @@
"@graphql-typed-document-node/core": "^3",
"@playwright/test": "^1.43.1",
"@sunodo/wagmi-plugin-hardhat-deploy": "^0.2",
"@testing-library/jest-dom": "^6.4.8",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/react": "^16.0.0",
"@types/node": "^20",
"@types/ramda": "^0.30.1",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.1.0",
"@vitest/coverage-v8": "0.34.2",
"@vitest/coverage-v8": "^2.0.5",
"@vitest/ui": "^2.0.5",
Copy link
Copy Markdown
Contributor Author

@nevendyulgerov nevendyulgerov Sep 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this package so that we can use the Vitest UI if we want with the yarn test:ui script.

"@wagmi/cli": "^2",
"dotenv-cli": "7.3.0",
"eslint": "^8",
"eslint-config-cartesi": "*",
"happy-dom": "^15.0.0",
"jsdom": "22.1.0",
"npm-run-all": "^4",
"postcss": "^8",
"postcss-preset-mantine": "^1.12.3",
"postcss-simple-vars": "^7",
"ts-node": "^10",
"typescript": "^5",
"vitest": "0.34.2"
"vitest": "^2.0.5"
}
}
12 changes: 6 additions & 6 deletions apps/web/test/components/connection/connectionForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ describe("connectionForm", () => {
).toBeInTheDocument();

expect(screen.getByTestId("icon-test-inactive")).toBeInTheDocument();
expect(screen.getByText("Save")).toBeInTheDocument();
expect(screen.getByTestId("connection-save")).toBeInTheDocument();
Copy link
Copy Markdown
Contributor Author

@nevendyulgerov nevendyulgerov Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests started failing after the latest rebase. Probably something in @testing-library/* or @mantine/* changed in a patch version, but I haven't dug into this further.

});

it("should present a list of applications suggestions when click on address input", () => {
Expand Down Expand Up @@ -229,7 +229,7 @@ describe("connectionForm", () => {

render(<AppConnectionFormE />);

fireEvent.click(screen.getByText("Save"));
fireEvent.click(screen.getByTestId("connection-save"));

expect(
screen.getByText("Address is a required field!"),
Expand Down Expand Up @@ -277,7 +277,7 @@ describe("connectionForm", () => {
screen.getByText("This application responded with"),
).toBeInTheDocument();

fireEvent.click(screen.getByText("Save"));
fireEvent.click(screen.getByTestId("connection-save"));

expect(addConnection).toHaveBeenCalledWith(
{ address, url },
Expand Down Expand Up @@ -324,7 +324,7 @@ describe("connectionForm", () => {
screen.getByText("This application responded with"),
).toBeInTheDocument();

fireEvent.click(screen.getByText("Save"));
fireEvent.click(screen.getByTestId("connection-save"));

expect(addConnection).toHaveBeenCalledWith(
{ address, url },
Expand Down Expand Up @@ -371,7 +371,7 @@ describe("connectionForm", () => {
screen.getByText("This application responded with"),
).toBeInTheDocument();

fireEvent.click(screen.getByText("Save"));
fireEvent.click(screen.getByTestId("connection-save"));

expect(addConnection).toHaveBeenCalledTimes(0);
});
Expand Down Expand Up @@ -407,7 +407,7 @@ describe("connectionForm", () => {
target: { value: url },
});

fireEvent.click(screen.getByText("Save"));
fireEvent.click(screen.getByTestId("connection-save"));

expect(addConnection).not.toHaveBeenCalled();
expect(notificationsMock.show).toHaveBeenCalledWith({
Expand Down
13 changes: 10 additions & 3 deletions apps/web/test/components/inputs/inputDetailsView.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,19 @@ describe("Input details view component", () => {
it("should try to parse the inputs payload As Text", () => {
render(<View input={inputSample} />);

fireEvent.click(screen.getByText("As Text"));
fireEvent.click(
screen.getByText("As Text").parentNode as HTMLLabelElement,
);

expect(screen.getByDisplayValue("joinGame")).toBeInTheDocument();
});

it("should try to parse the inputs payload As JSON", () => {
render(<View input={inputSample} />);

fireEvent.click(screen.getByText("As JSON"));
fireEvent.click(
screen.getByText("As JSON").parentNode as HTMLLabelElement,
);

expect(screen.getByDisplayValue("joinGame")).toBeInTheDocument();
});
Expand Down Expand Up @@ -196,7 +200,10 @@ describe("Input details view component", () => {

const reportsPanel = screen.getByTestId("panel-reports");

fireEvent.click(getByText(reportsPanel, "As Text"));
fireEvent.click(
getByText(reportsPanel, "As Text")
.parentNode as HTMLLabelElement,
);

expect(screen.getByDisplayValue("Qh4+")).toBeVisible();
});
Expand Down
Loading