Adding support for typed dict in schema conversion#176
Draft
lucyliulee wants to merge 4 commits intomainfrom
Draft
Adding support for typed dict in schema conversion#176lucyliulee wants to merge 4 commits intomainfrom
lucyliulee wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds TypedDict support to the schema converter, enabling proper JSON schema generation for tools with nested object parameters. This fixes a critical issue where OpenAI models reject
list[dict]parameters because the generated schema lacks property definitions required by OpenAI.Problem:
list[dict]in tool parameters generates{"type": "object"}without propertiesadditionalPropertiesis required to be supplied and to be falseSolution:
schema_converter.pystrictflag through recursive type resolutionExample:
Type of change
Testing
Unit Tests (13 new tests):
uv run pytest tests/test_llm_agent_schema_converter.py -vIntegration Tests:
uv run python line/llm_agent/scripts/test_provider.py --tests nested_objects,nested_objects_failChecklist
make format