fix: pass world address as array to arcadeAtom subscription#280
Merged
MartianGreed merged 2 commits intomainfrom Feb 19, 2026
Merged
fix: pass world address as array to arcadeAtom subscription#280MartianGreed merged 2 commits intomainfrom
MartianGreed merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MartianGreed
force-pushed
the
fix/arcade-atom-world-address
branch
from
f87a669 to
36434a2
Compare
MartianGreed
force-pushed
the
fix/arcade-atom-world-address
branch
from
36434a2 to
3b8fc17
Compare
MartianGreed
force-pushed
the
fix/arcade-atom-world-address
branch
from
3b8fc17 to
32ca3f4
Compare
The worldAddresses parameter of createEntityQueryWithUpdatesAtom expects string[] but was receiving a plain string. This caused onEntityUpdated to not properly filter by world address, resulting in entity subscription updates (order create/cancel) not being caught.
MartianGreed
force-pushed
the
fix/arcade-atom-world-address
branch
from
32ca3f4 to
397f5d9
Compare
MartianGreed
force-pushed
the
fix/arcade-atom-world-address
branch
from
397f5d9 to
5ee5b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
arcadeAtomsubscription wasn't catching entity updates (order create/cancel).Cause
createEntityQueryWithUpdatesAtomexpectsworldAddressesasstring[] | null | undefined, butmainnetConfig.manifest.world.address(a plain string) was passed directly. This meant the underlyingonEntityUpdatedgRPC subscription wasn't properly filtering by world address, so live updates were silently dropped.Fix
Wrap the world address in an array:
[mainnetConfig.manifest.world.address]Initial query was unaffected since
ToriiQueryBuilderhandles the address differently.