fix: verify ownership on stale marketplace listings#285
Merged
MartianGreed merged 3 commits intomainfrom Feb 19, 2026
Merged
Conversation
SDK (getToken): - Add ownership verification to getToken() listings - Cross-check on-chain token balances before returning listings - Add expiration check (filter out expired orders) - New verifyOwnership option (default: true) Client (token detail page): - Add collectionOrdersVerifiedAtom that cross-checks ownership via collectionOwnershipAtom (same pattern as verifiedCollectionOrdersAtom but returns OrderModel[] instead of ListingWithUsd[]) - Switch useTokenDetailViewModel to use collectionOrdersVerifiedAtom so token detail page no longer shows stale listings Fixes: stale orders shown when NFT owner transfers token after listing
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an NFT owner creates a sell listing and then transfers the token to another wallet, the listing remains in
Placedstatus on-chain but is unfillable. These stale listings were shown to users in several code paths.What changed
SDK (
getToken())fetchTokenBalances()to confirm the listing owner still holds the tokenverifyOwnershipoption (defaults totrue, setfalseto skip)Client (token detail page)
collectionOrdersVerifiedAtom— same shape ascollectionOrdersAtom({ [token]: OrderModel[] }) but filters throughcollectionOwnershipAtomto verify on-chain ownershipuseTokenDetailViewModelnow usescollectionOrdersVerifiedAtominstead ofcollectionOrdersAtomPreviously already verified ✅
listCollectionListings()— already hadverifyOwnership(default on)verifiedCollectionOrdersAtom— already used in collection items viewNow also verified ✅
getToken()— SDK levelcollectionOrdersVerifiedAtomStill unverified (by design)
getCollectionOrders()— raw query, returns all orders regardless of status (API contract)ordersAtom/listingsAtom— global atoms, used for aggregation