Harden NFT collection SQL reads and tests#287
Open
ponderingdemocritus wants to merge 14 commits intomainfrom
Open
Harden NFT collection SQL reads and tests#287ponderingdemocritus wants to merge 14 commits intomainfrom
ponderingdemocritus wants to merge 14 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes NFT collection SQL correctness in the Arcade SDK by grouping OR trait predicates, switching trait matching from LIKE to exact equality, and counting distinct selected trait names correctly for HAVING clauses. It also hardens edge SQL query construction by normalizing token IDs, sanitizing invalid order IDs, and stabilizing pagination limits and cursor behavior. Tests were expanded to lock these behaviors in packages/arcade-ts/src/marketplace/filters.test.ts and packages/arcade-ts/src/marketplace/client.edge.test.ts, and @cartridge/arcade tests are passing locally. The branch also includes the current pnpm-lock.yaml update present in the workspace diff.