fix(starterpack): skip self-referral to prevent fee leakage#292
Merged
fix(starterpack): skip self-referral to prevent fee leakage#292
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
When the Controller passes the buyer's own address as the referrer, the referral fee was deducted from the payment_receiver's share but stayed on the buyer's account (self-transfer). This caused the game owner to receive less than expected. Skip referral fee when ref_addr == payer so the owner gets the full base_price. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
broody
force-pushed
the
fix/starterpack-self-referral
branch
from
8abbbe3 to
15d0d3e
Compare
bal7hazar
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_price - referral_feeinstead of the fullbase_priceref_addr == payerTest plan
test_sp_fees_self_referral_ignored— verifies creator gets full base_price when spender is passed as referrer🤖 Generated with Claude Code