Skip to content

feat: remove supported-platforms feature gate#2335

Merged
broody merged 2 commits intomainfrom
feat/remove-supported-platforms-feature-gate
Jan 21, 2026
Merged

feat: remove supported-platforms feature gate#2335
broody merged 2 commits intomainfrom
feat/remove-supported-platforms-feature-gate

Conversation

@broody
Copy link
Contributor

@broody broody commented Jan 17, 2026

Summary

This PR removes the supported-platforms feature flag, enabling all network platforms by default in the wallet selection drawer.

Changes

packages/keychain/src/components/purchasenew/checkout/onchain/wallet-drawer.tsx

  • Removed the isSupportedPlatformsEnabled feature flag hook call
  • Updated selectedNetworks useMemo to always include all platforms: starknet, ethereum, base, arbitrum, and optimism
  • Removed isSupportedPlatformsEnabled from the dependency array
  • Minor formatting improvements

packages/keychain/src/hooks/features.tsx

  • Removed supported-platforms from the Feature type union

Result

All network platforms are now always available in the wallet selection drawer without requiring feature flag enablement.

@vercel
Copy link

vercel bot commented Jan 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
controller-example-next Ready Ready Preview Jan 21, 2026 8:56pm
keychain Ready Ready Preview Jan 21, 2026 8:56pm
keychain-storybook Ready Ready Preview Jan 21, 2026 8:56pm

Request Review

@claude
Copy link
Contributor

claude bot commented Jan 17, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

- Remove feature flag check for supported-platforms in wallet-drawer.tsx
- Always show all network platforms (starknet, ethereum, base, arbitrum, optimism)
- Remove supported-platforms from Feature type in features.tsx
@broody broody force-pushed the feat/remove-supported-platforms-feature-gate branch from 43bd687 to 18e9c37 Compare January 21, 2026 20:54
@broody broody merged commit 08a73e3 into main Jan 21, 2026
12 checks passed
@broody broody deleted the feat/remove-supported-platforms-feature-gate branch January 21, 2026 21:00
@claude
Copy link
Contributor

claude bot commented Jan 21, 2026

Claude finished @broody's task —— View job


Analyzing controller changes and updating documentation

I'll analyze the PR changes that removed the supported-platforms feature gate and determine if any documentation updates are needed in the docs repository.

Todo List:

  • Check the docs-repo directory structure and existing documentation
  • Review the changed files to understand the technical changes
  • Assess if the feature flag removal affects user-facing documentation
  • Update documentation if needed or confirm no updates required

Analysis of Changes:
The PR removed the supported-platforms feature flag, which was used to conditionally enable network platforms in the wallet selection drawer. Key changes:

  1. wallet-drawer.tsx: Removed isSupportedPlatformsEnabled feature flag check and now always includes all platforms (starknet, ethereum, base, arbitrum, optimism) in mainnet
  2. features.tsx: Removed supported-platforms from the Feature type union

Documentation Assessment:
After reviewing the documentation files in the docs-repo, I found:

  1. No direct references to the supported-platforms feature flag in any documentation files
  2. No impact on user-facing features - This was an internal feature flag that controlled platform availability behind the scenes
  3. No API or configuration changes - Users don't directly interact with or configure this feature flag

Conclusion:
No documentation updates are required. The removal of the supported-platforms feature flag is an internal implementation detail that:

  • Does not change any user-facing APIs or configuration options
  • Does not affect the documented behavior of the Controller SDK
  • Simply makes all network platforms (ethereum, base, arbitrum, optimism) always available instead of being conditionally enabled
  • Has no impact on the existing documentation for starterpacks, coinbase onramp, signer management, or other features

The change improves user experience by ensuring all supported networks are always available without requiring feature flag configuration, but this doesn't necessitate any documentation updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant