Skip to content

chore: update @cartridge/ui#2346

Merged
broody merged 1 commit intomainfrom
update-ui
Jan 23, 2026
Merged

chore: update @cartridge/ui#2346
broody merged 1 commit intomainfrom
update-ui

Conversation

@tarrencev
Copy link
Contributor

Updates @cartridge/ui dependency to point to commit 301966b

@vercel
Copy link

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
controller-example-next Ready Ready Preview Jan 23, 2026 9:46pm
keychain Error Error Jan 23, 2026 9:46pm
keychain-storybook Ready Ready Preview Jan 23, 2026 9:46pm

Request Review

@claude
Copy link
Contributor

claude bot commented Jan 23, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@broody broody merged commit e6bab90 into main Jan 23, 2026
9 of 12 checks passed
@broody broody deleted the update-ui branch January 23, 2026 21:55
@claude
Copy link
Contributor

claude bot commented Jan 23, 2026

Claude finished @tarrencev's task —— View job


Analyzing Controller Repository Changes

I'll analyze the changes in PR #2346 and determine if any documentation updates are needed in the docs repository.

Task List:

  • Review the changed files in the controller repository
  • Check what documentation exists in the docs-repo directory
  • Determine if @cartridge/ui dependency update requires documentation changes
  • Update documentation files if needed, or confirm no updates are required

Analysis of Changes:

The PR updated the @cartridge/ui dependency from one commit to another (commit 301966b) in:

  • package.json line 38: "@cartridge/ui": "github:cartridge-gg/ui#301966b"
  • pnpm-workspace.yaml line 10: "@cartridge/ui": "github:cartridge-gg/ui#301966b"
  • pnpm-lock.yaml: Updated lock file entries to reflect the new commit

This is a pure dependency update without any functional changes to the controller library itself.

Documentation Review:

I found that the @cartridge/ui package is referenced in the documentation at:

  • docs-repo/src/pages/controller/examples/react.md:127 - Shows import of Button component from @cartridge/ui

Conclusion:

No documentation updates are required.

The PR is a pure dependency update that points to a newer commit of the @cartridge/ui library. Since:

  1. The documentation doesn't reference specific version numbers or commit hashes of @cartridge/ui
  2. The API usage shown in the documentation (importing Button component) remains the same
  3. This is an internal dependency update that doesn't affect the public API of the controller
  4. No breaking changes or new features are introduced that would require documentation updates

The existing documentation remains accurate and up-to-date with this dependency change.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants