Skip to content

fix(keychain): hide 'proceed with caution' warning for slot login#2351

Merged
broody merged 1 commit intomainfrom
fix-slogin
Jan 27, 2026
Merged

fix(keychain): hide 'proceed with caution' warning for slot login#2351
broody merged 1 commit intomainfrom
fix-slogin

Conversation

@broody
Copy link
Contributor

@broody broody commented Jan 27, 2026

Summary

  • Hide the "Please proceed with caution" warning when logging into slot (Cartridge's own site)
  • The warning is intended for external sites embedding the keychain wallet with unverified domains
  • Slot login at https://x.cartridge.gg should not display this error alert

Changes

  • Updated CreateController to check !isSlot before showing the unverified theme warning
  • Added isSlot prop to CreateControllerForm and CreateControllerView components
  • Added test case to verify the warning is hidden when isSlot is true

Testing

  • Ran pnpm lint:check
  • Added unit test for the new behavior

@vercel
Copy link

vercel bot commented Jan 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
controller-example-next Ready Ready Preview Jan 27, 2026 7:41pm
keychain Ready Ready Preview Jan 27, 2026 7:41pm
keychain-storybook Ready Ready Preview Jan 27, 2026 7:41pm

Request Review

@claude
Copy link
Contributor

claude bot commented Jan 27, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@broody broody merged commit 11f7a0e into main Jan 27, 2026
12 checks passed
@broody broody deleted the fix-slogin branch January 27, 2026 20:00
@claude
Copy link
Contributor

claude bot commented Jan 27, 2026

Claude finished @broody's task —— View job


Analyzing PR changes for documentation updates

I'll analyze the controller repository PR changes and determine if documentation updates are needed.

Task List:

  • Review the changed files to understand the functionality
  • Check existing documentation in docs-repo directory
  • Determine if documentation updates are needed for this change
  • Update documentation if required

Change Summary:

  • Title: fix(keychain): hide 'proceed with caution' warning for slot login
  • Files: CreateController.test.tsx, CreateController.tsx
  • Purpose: Hide warning for Cartridge's own site (x.cartridge.gg) vs external sites

Analysis Complete:

After thoroughly analyzing the PR changes and existing documentation, no documentation updates are needed for this change. Here's why:

  1. Internal Implementation Detail: This is purely an internal UX fix that adds logic to hide the "Please proceed with caution" warning when users log into Cartridge's own site (slot/x.cartridge.gg)

  2. No User-Facing API Changes: The change only adds an internal isSlot prop that's used by the keychain application itself - it's not part of the public API that developers would use

  3. No New Features: This doesn't add new functionality - it simply removes an inappropriate warning that was showing on Cartridge's own domain

  4. Documentation Already Covers Core Concepts: The existing docs already cover verified vs unverified domains in the sessions documentation and presets, but this specific UI warning behavior is an implementation detail

  5. Bug Fix vs Feature: This is categorized as a bug fix that improves UX by not showing domain warnings on the official Cartridge site

The documentation remains accurate and complete for end users. This change only affects the internal behavior of the keychain UI and doesn't impact how developers integrate with the Controller SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant