Skip to content

fix: enhance preset verification for Capacitor#2369

Merged
kronosapiens merged 1 commit intomainfrom
fix/capacitor-verification
Feb 4, 2026
Merged

fix: enhance preset verification for Capacitor#2369
kronosapiens merged 1 commit intomainfrom
fix/capacitor-verification

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 4, 2026

Summary

  • Enhanced preset verification to better support Capacitor applications.
  • Added capacitor:// to the automatic verification bypass (alongside localhost) to simplify development for native apps using capacitor://localhost.
  • Refactored allowedOrigins calculation in useConnectionValue to reduce redundancy.

Test plan

  • Verify that a Capacitor app using capacitor://localhost is automatically verified.
  • Verify that verification still works correctly in embedded (iframe) mode.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 4, 2026 1:17am
keychain Ready Ready Preview Feb 4, 2026 1:17am
keychain-storybook Ready Ready Preview Feb 4, 2026 1:17am

Request Review

Adds an onPlay callback option to starterpack flows and routes Play
clicks through it. The keychain iframe now closes before calling the
callback and falls back to the existing close behavior when absent.
@broody broody force-pushed the fix/capacitor-verification branch from 2368fc6 to 564b0e3 Compare February 4, 2026 01:15
@broody broody changed the title fix: enhance preset verification for Capacitor and custom schemes fix: enhance preset verification for Capacitor Feb 4, 2026
@claude
Copy link
Contributor

claude bot commented Feb 4, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@kronosapiens kronosapiens merged commit 763e7a0 into main Feb 4, 2026
13 checks passed
@kronosapiens kronosapiens deleted the fix/capacitor-verification branch February 4, 2026 16:24
@claude
Copy link
Contributor

claude bot commented Feb 4, 2026

Claude finished @broody's task —— View job


Documentation Analysis Complete

I've analyzed the merged PR changes and existing documentation in the docs repository.

Task List:

  • Analyze the changed files to understand the Capacitor enhancements
  • Check existing documentation structure in docs-repo
  • Review current Capacitor integration documentation
  • Determine what documentation updates are needed
  • Update or create appropriate documentation files

Analysis Summary:

The PR enhanced preset verification by adding capacitor:// protocol support alongside localhost for automatic verification bypass. The key changes in /packages/keychain/src/hooks/connection.ts at lines 444-447 and 472-475 now include:

// Always consider localhost and capacitor as verified for development
const isLocalhost = 
  redirectOrigin.includes("localhost") || 
  redirectOrigin.startsWith("capacitor://");

Documentation Assessment:

No documentation updates are needed because:

  1. Internal Enhancement: The change is an internal verification bypass that improves the developer experience but doesn't change the public API or user-facing integration patterns.

  2. Development Convenience: Adding capacitor:// to the automatic verification bypass (alongside localhost) is a behind-the-scenes improvement that simplifies development for Capacitor apps using capacitor://localhost.

  3. Existing Documentation is Complete: The current Capacitor documentation at /docs-repo/src/pages/controller/native/capacitor.md comprehensively covers:

    • Setup and configuration
    • Deep link handling
    • Session management
    • Platform-specific requirements
    • Complete working examples
  4. No Breaking Changes: The enhancement is additive and doesn't modify existing integration patterns or require changes to user code.

The existing documentation remains accurate and complete for Capacitor integration. Users will benefit from the improved verification automatically without needing to change their implementation.

@github-actions github-actions bot mentioned this pull request Feb 4, 2026
github-actions bot added a commit that referenced this pull request Feb 4, 2026
- Added Coinbase sandbox configuration fix (#2371)
- Added Capacitor preset verification enhancement (#2369)
- Updated release date to 2026-02-04

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Larko <59736843+Larkooo@users.noreply.github.com>
kronosapiens pushed a commit that referenced this pull request Feb 5, 2026
- Added Coinbase sandbox configuration fix (#2371)
- Added Capacitor preset verification enhancement (#2369)
- Updated release date to 2026-02-04

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Larko <59736843+Larkooo@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants