Skip to content

fix: set coinbase sandbox correctly#2371

Merged
broody merged 1 commit intomainfrom
fix-coinbase-sandbox
Feb 4, 2026
Merged

fix: set coinbase sandbox correctly#2371
broody merged 1 commit intomainfrom
fix-coinbase-sandbox

Conversation

@broody
Copy link
Contributor

@broody broody commented Feb 4, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 4, 2026 8:21pm
keychain Ready Ready Preview Feb 4, 2026 8:21pm
keychain-storybook Ready Ready Preview Feb 4, 2026 8:21pm

Request Review

@claude
Copy link
Contributor

claude bot commented Feb 4, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@broody broody merged commit b6de9c7 into main Feb 4, 2026
12 checks passed
@broody broody deleted the fix-coinbase-sandbox branch February 4, 2026 20:31
@claude
Copy link
Contributor

claude bot commented Feb 4, 2026

Claude finished @broody's task —— View job


Documentation Sync Analysis

Analyzing the Coinbase sandbox fix and updating documentation accordingly.

Tasks:

  • Analyze changes in the merged PR files
  • Explore docs-repo directory structure
  • Determine if documentation updates are needed
  • Update documentation files if required

Analysis Results

I've analyzed the changes in the merged PR titled "fix: set coinbase sandbox correctly". The key changes are:

Key Changes Made:

  • Fixed Coinbase sandbox mode to properly use !isMainnet logic across all Coinbase-related functionality
  • Ensures sandbox mode is enabled for testnet/development environments and disabled for mainnet
  • Affects Coinbase quote fetching, order creation, and transaction monitoring

Documentation Review:
The existing coinbase-onramp.md documentation already correctly covers:

  • Sandbox environment usage with automatic toggling based on network (line 126: "automatically enabled on testnets")
  • This matches the implemented behavior where sandbox: !isMainnet

Conclusion:
No documentation updates are needed. The existing documentation at /controller/coinbase-onramp.md already accurately describes the sandbox behavior that was fixed in this PR. The fix ensures the implementation matches the documented behavior.

@github-actions github-actions bot mentioned this pull request Feb 4, 2026
github-actions bot added a commit that referenced this pull request Feb 4, 2026
- Added Coinbase sandbox configuration fix (#2371)
- Added Capacitor preset verification enhancement (#2369)
- Updated release date to 2026-02-04

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Larko <59736843+Larkooo@users.noreply.github.com>
kronosapiens pushed a commit that referenced this pull request Feb 5, 2026
- Added Coinbase sandbox configuration fix (#2371)
- Added Capacitor preset verification enhancement (#2369)
- Updated release date to 2026-02-04

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Larko <59736843+Larkooo@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant