Skip to content

fix: inline changelog generation into release-dispatch#2379

Merged
kronosapiens merged 1 commit intomainfrom
kronosapiens/inline-changelog
Feb 5, 2026
Merged

fix: inline changelog generation into release-dispatch#2379
kronosapiens merged 1 commit intomainfrom
kronosapiens/inline-changelog

Conversation

@kronosapiens
Copy link
Contributor

Summary

  • Fixes a race condition where the changelog-generation workflow pushed a second commit to release PRs after CI checks had already started on the first commit, leaving required status checks (ts-lint, ts, storybook) permanently pending
  • Moves changelog generation into release-dispatch before PR creation so peter-evans/create-pull-request includes both version bumps and changelog in a single commit
  • Deletes the now-unnecessary changelog-generation workflow

Test plan

  • Run release-dispatch workflow and verify the PR is created with changelog included in the initial commit
  • Verify all required CI checks (ts-lint, ts, storybook) run and complete on the PR

🤖 Generated with Claude Code

@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 5, 2026 10:36pm
keychain Ready Ready Preview Feb 5, 2026 10:36pm
keychain-storybook Ready Ready Preview Feb 5, 2026 10:36pm

Request Review


- name: Generate Changelog with Claude
id: changelog
uses: anthropics/claude-code-action@beta

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'release-dispatch' step
Uses Step: changelog
uses 'anthropics/claude-code-action' with ref 'beta', not a pinned commit hash
@claude
Copy link
Contributor

claude bot commented Feb 5, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


The changelog-generation workflow ran as a separate job after the release
PR was created, pushing a second commit to the PR branch. This caused a
race condition where the test/quality CI checks would run on the first
commit but not re-trigger on the changelog commit, leaving required
status checks permanently pending and blocking the PR from merging.

Move changelog generation into release-dispatch before PR creation so
that peter-evans/create-pull-request includes both version bumps and
changelog in a single commit. Delete the now-unnecessary
changelog-generation workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kronosapiens kronosapiens enabled auto-merge (squash) February 5, 2026 22:39
@kronosapiens kronosapiens merged commit 2c879ec into main Feb 5, 2026
12 checks passed
@kronosapiens kronosapiens deleted the kronosapiens/inline-changelog branch February 5, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants