Skip to content

test: add controller disconnect localStorage cleanup regression#2414

Merged
kronosapiens merged 5 commits intomainfrom
fixdisconnect
Feb 13, 2026
Merged

test: add controller disconnect localStorage cleanup regression#2414
kronosapiens merged 5 commits intomainfrom
fixdisconnect

Conversation

@tarrencev
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Feb 13, 2026 9:07pm
keychain Ready Ready Preview Feb 13, 2026 9:07pm
keychain-storybook Ready Ready Preview Feb 13, 2026 9:07pm

Request Review

@kronosapiens kronosapiens merged commit e4bc511 into main Feb 13, 2026
11 checks passed
@kronosapiens kronosapiens deleted the fixdisconnect branch February 13, 2026 21:14
@claude
Copy link
Contributor

claude bot commented Feb 13, 2026

Claude finished @tarrencev's task —— View job


Analyzing the controller PR changes and updating documentation accordingly...

Todo List

  • Read the changed controller files to understand disconnect functionality
  • Explore docs-repo directory structure
  • Determine if documentation updates are needed
  • Update documentation files if required
  • Commit and push any changes

Analysis Complete

After analyzing the PR changes and existing documentation, I've determined that no documentation updates are needed for this PR.

What the PR added:

  • A regression test for controller disconnect localStorage cleanup
  • Ensures the disconnect() method properly cleans up Cartridge-specific localStorage keys while preserving other application data

Why no documentation update is needed:

  1. Internal improvement: This is primarily a bug fix/test addition to ensure proper cleanup behavior
  2. Existing coverage: The disconnect functionality is already documented in the React examples and session management docs
  3. Implementation detail: localStorage cleanup is an internal implementation detail that doesn't affect the public API or user-facing behavior
  4. Defensive behavior: The cleanup only affects Cartridge-specific keys (@cartridge/* and lastUsedConnector), preserving other application data

The existing documentation in examples/react.md and sessions.md already covers how to use the disconnect() method from a user perspective, which is sufficient for developers integrating the controller.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants