Skip to content

fix: set authenticatorAttachment to platform on iOS for passkey creation #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
broody merged 1 commit into from
Feb 13, 2026
Merged

fix: set authenticatorAttachment to platform on iOS for passkey creation #2417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/keychain/src/hooks/account.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,15 @@ const createCredentials = async (
) => {
if (!beginRegistration.publicKey) return;
if (beginRegistration.publicKey?.authenticatorSelection) {
const isIOS = /iPad|iPhone|iPod/.test(navigator.userAgent);
if (!hasPlatformAuthenticator || navigator.userAgent.indexOf("Win") != -1)
beginRegistration.publicKey.authenticatorSelection.authenticatorAttachment =
"cross-platform";
else if (isIOS)
// Explicitly set "platform" on iOS so Chrome iOS (Google Password Manager)
// shows "Create Passkey" instead of a "Sign in" dialog
beginRegistration.publicKey.authenticatorSelection.authenticatorAttachment =
"platform";
else
beginRegistration.publicKey.authenticatorSelection.authenticatorAttachment =
undefined;
Expand Down
97 changes: 97 additions & 0 deletions packages/keychain/src/utils/api/generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2982,6 +2982,11 @@ export type Mutation = {
finalizeLogin: Scalars["String"];
finalizeRegistration: Account;
increaseBudget: Paymaster;
/**
* Perform Prove Identity Verify v2.
* Submits consumer PII for verification.
*/
proveVerify: ProveVerifyResponse;
register: Account;
removeAllPolicies: Scalars["Boolean"];
removeFromTeam: Scalars["Boolean"];
Expand Down Expand Up @@ -3175,6 +3180,10 @@ export type MutationIncreaseBudgetArgs = {
unit: FeeUnit;
};

export type MutationProveVerifyArgs = {
input: ProveVerifyInput;
};

export type MutationRegisterArgs = {
chainId: Scalars["String"];
owner: SignerInput;
Expand Down Expand Up @@ -4331,6 +4340,77 @@ export type Project = {
project: Scalars["String"];
};

export type ProveAddressResult = {
__typename?: "ProveAddressResult";
addressScore: Scalars["Int"];
city: Scalars["Boolean"];
distance: Scalars["Float"];
postalCode: Scalars["Boolean"];
region: Scalars["Boolean"];
street: Scalars["Boolean"];
streetNumber: Scalars["Int"];
};

export type ProveEmailResult = {
__typename?: "ProveEmailResult";
emailAddress: Scalars["Boolean"];
};

export type ProveIdentifiersResult = {
__typename?: "ProveIdentifiersResult";
dob: Scalars["Boolean"];
driversLicenseNumber: Scalars["Boolean"];
driversLicenseState: Scalars["Boolean"];
last4: Scalars["Boolean"];
ssn: Scalars["Boolean"];
};

export type ProveNameResult = {
__typename?: "ProveNameResult";
firstName: Scalars["Int"];
lastName: Scalars["Int"];
nameScore: Scalars["Int"];
};

export type ProveVerifyInput = {
address?: InputMaybe<Scalars["String"]>;
city?: InputMaybe<Scalars["String"]>;
dob?: InputMaybe<Scalars["String"]>;
emailAddress?: InputMaybe<Scalars["String"]>;
extendedAddress?: InputMaybe<Scalars["String"]>;
/** Use the UAT sandbox environment instead of production. */
firstName?: InputMaybe<Scalars["String"]>;
last4?: InputMaybe<Scalars["String"]>;
lastName?: InputMaybe<Scalars["String"]>;
phoneNumber?: InputMaybe<Scalars["String"]>;
postalCode?: InputMaybe<Scalars["String"]>;
region?: InputMaybe<Scalars["String"]>;
ssn?: InputMaybe<Scalars["String"]>;
};

export type ProveVerifyResponse = {
__typename?: "ProveVerifyResponse";
address?: Maybe<ProveAddressResult>;
carrier?: Maybe<Scalars["String"]>;
cipConfidence?: Maybe<Scalars["String"]>;
countryCode?: Maybe<Scalars["String"]>;
description: Scalars["String"];
email?: Maybe<ProveEmailResult>;
enrollStatus?: Maybe<Scalars["String"]>;
identifiers?: Maybe<ProveIdentifiersResult>;
lineType?: Maybe<Scalars["String"]>;
multiCipConfidence?: Maybe<Scalars["String"]>;
multiVerified?: Maybe<Scalars["Boolean"]>;
name?: Maybe<ProveNameResult>;
payfoneAlias?: Maybe<Scalars["String"]>;
phoneNumber?: Maybe<Scalars["String"]>;
reasonCodes?: Maybe<Array<Scalars["String"]>>;
status: Scalars["Int"];
success: Scalars["Boolean"];
transactionId?: Maybe<Scalars["String"]>;
verified?: Maybe<Scalars["Boolean"]>;
};

export enum PurchaseType {
Credits = "CREDITS",
/** @deprecated Starterpack purchases are now handled client-side */
Expand Down Expand Up @@ -5385,6 +5465,7 @@ export type Session = Node & {
/** Whether the session has been revoked */
isRevoked: Scalars["Boolean"];
metadata?: Maybe<SessionMetadata>;
sessionKeyGUID?: Maybe<Scalars["String"]>;
signer?: Maybe<Signer>;
updatedAt: Scalars["Time"];
};
Expand Down Expand Up @@ -5524,6 +5605,22 @@ export type SessionWhereInput = {
isRevokedNEQ?: InputMaybe<Scalars["Boolean"]>;
not?: InputMaybe<SessionWhereInput>;
or?: InputMaybe<Array<SessionWhereInput>>;
/** session_key_guid field predicates */
sessionKeyGUID?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDContains?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDContainsFold?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDEqualFold?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDGT?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDGTE?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDHasPrefix?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDHasSuffix?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDIn?: InputMaybe<Array<Scalars["String"]>>;
sessionKeyGUIDIsNil?: InputMaybe<Scalars["Boolean"]>;
sessionKeyGUIDLT?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDLTE?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDNEQ?: InputMaybe<Scalars["String"]>;
sessionKeyGUIDNotIn?: InputMaybe<Array<Scalars["String"]>>;
sessionKeyGUIDNotNil?: InputMaybe<Scalars["Boolean"]>;
/** updated_at field predicates */
updatedAt?: InputMaybe<Scalars["Time"]>;
updatedAtGT?: InputMaybe<Scalars["Time"]>;
Expand Down
Loading