Skip to content

swap screen review#2456

Open
rsodre wants to merge 16 commits intomainfrom
rsodre/swap-review-screen
Open

swap screen review#2456
rsodre wants to merge 16 commits intomainfrom
rsodre/swap-review-screen

Conversation

@rsodre
Copy link
Collaborator

@rsodre rsodre commented Mar 2, 2026

  • On the confirmation screen, identify swaps in calls, by function names
  • Display buying and selling token cards, with increasing/decreasing colors
  • Added Advanced cog icon and view, displaying detailed calls contents

@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 6, 2026 1:11pm
keychain Ready Ready Preview Mar 6, 2026 1:11pm
keychain-storybook Ready Ready Preview Mar 6, 2026 1:11pm

Request Review

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 59.51557% with 234 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.38%. Comparing base (34524ca) to head (34343eb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kages/keychain/src/components/swap/ConfirmSwap.tsx 2.63% 74 Missing ⚠️
...ain/src/components/inventory/collection/footer.tsx 0.00% 44 Missing ⚠️
...s/keychain/src/components/transaction/CallCard.tsx 8.33% 33 Missing ⚠️
packages/keychain/src/components/FeesRow.tsx 76.71% 17 Missing ⚠️
packages/keychain/src/hooks/calldata-decode.ts 80.30% 13 Missing ⚠️
...ents/inventory/collection/collectible-purchase.tsx 0.00% 12 Missing ⚠️
...nents/inventory/collection/collection-purchase.tsx 0.00% 12 Missing ⚠️
packages/keychain/src/components/Fees.tsx 85.48% 7 Missing and 2 partials ⚠️
.../src/components/transaction/ConfirmTransaction.tsx 33.33% 8 Missing ⚠️
.../src/components/transaction/TransactionSummary.tsx 87.87% 8 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2456      +/-   ##
==========================================
+ Coverage   20.98%   21.38%   +0.40%     
==========================================
  Files         319      323       +4     
  Lines       34610    34958     +348     
  Branches     1062     1097      +35     
==========================================
+ Hits         7263     7477     +214     
- Misses      27333    27465     +132     
- Partials       14       16       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant