Skip to content

feat: enable apple pay via triple-click on review purchase icon#2457

Merged
broody merged 1 commit intomainfrom
feat/apple-pay-triple-click
Mar 2, 2026
Merged

feat: enable apple pay via triple-click on review purchase icon#2457
broody merged 1 commit intomainfrom
feat/apple-pay-triple-click

Conversation

@broody
Copy link
Contributor

@broody broody commented Mar 2, 2026

No description provided.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 2, 2026 9:55pm
keychain Ready Ready Preview Mar 2, 2026 9:55pm
keychain-storybook Ready Ready Preview Mar 2, 2026 9:55pm

Request Review

@broody broody merged commit f43b342 into main Mar 2, 2026
12 checks passed
@broody broody deleted the feat/apple-pay-triple-click branch March 2, 2026 21:59
@claude
Copy link
Contributor

claude bot commented Mar 2, 2026

Claude finished @broody's task —— View job


Documentation Sync Analysis

  • Analyze PR changes
  • Determine if user-facing behavior changed
  • Make final determination

Analysis Complete

Change Summary: PR #2457 added a triple-click easter egg to the Review Purchase screen's gift icon that enables the Apple Pay feature flag.

Documentation Decision: ✅ No documentation updates needed

Reasoning:

  1. Internal implementation detail: This change adds a hidden easter egg (triple-click on the gift icon) to enable a feature flag. This is not a documented API, configuration option, or user-facing feature.

  2. Non-discoverable feature: Easter eggs and hidden feature enablers are intentionally undocumented. They are internal tools for testing and debugging, not part of the public API surface.

  3. Existing Apple Pay documentation: The docs-repo/src/pages/controller/coinbase-onramp.md file already documents Apple Pay functionality in the context of Coinbase onramp integration (line 74, 96). The triple-click mechanism is purely an internal activation method and doesn't change the documented behavior of Apple Pay itself.

  4. Adheres to documentation rules: Following the directive "DEFAULT TO NO CHANGES. Most code PRs do not need docs updates. Internal refactors, test changes, CI changes, and dependency bumps need nothing." This is an internal UI implementation detail.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant