Skip to content

fix: update apple pay pending screen#2460

Merged
broody merged 6 commits intomainfrom
fix/coinbase-popup-error-message-and-cancel-state
Mar 3, 2026
Merged

fix: update apple pay pending screen#2460
broody merged 6 commits intomainfrom
fix/coinbase-popup-error-message-and-cancel-state

Conversation

@broody
Copy link
Contributor

@broody broody commented Mar 3, 2026 •
edited
Loading

No description provided.

broody and others added 4 commits February 25, 2026 16:52
@broody
fix: preserve Coinbase error details and cancel terminal state
bcbe72e 
Capture error fields in the popup parser fallback so Coinbase error messages are displayed to users, and treat cancel events as failed terminal states to avoid showing a stale processing indicator.
@broody
fix: avoid regex backtracking in Coinbase error parsing
41ff2d3 
Replace fallback regex field extraction with a linear string scanner so Coinbase popup error parsing remains robust without risky regular expressions.
@broody
fix: tighten Coinbase popup transitions and add message tests
6bdda2e 
Apply strict Coinbase message parsing with explicit event-state transitions and add popup tests for stringified load, error, progress, and cancel postMessage events.
@broody @claude
fix: hide bridge and purchase steps in Apple Pay pending screen
6af58fc 
Temporarily hide the Layerswap transaction link and Starknet purchase
step for Apple Pay flow, showing only the Coinbase confirmation status.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link

vercel bot commented Mar 3, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
controller-example-next Ready Ready Preview Mar 3, 2026 6:44am
keychain Ready Ready Preview Mar 3, 2026 6:44am
keychain-storybook Ready Ready Preview Mar 3, 2026 6:44am

Request Review

@broody broody changed the title fix: hide bridge and purchase steps in Apple Pay pending screen fix: update apple pay pending screen Mar 3, 2026
@broody @claude
chore: format coinbase-popup test file
c67d691 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@broody broody merged commit b7456be into main Mar 3, 2026
12 checks passed
@broody broody deleted the fix/coinbase-popup-error-message-and-cancel-state branch March 3, 2026 06:52
@claude
Copy link
Contributor

claude bot commented Mar 3, 2026 •
edited
Loading

Claude finished @broody's task —— View job

Analyzing PR changes for documentation updates

  • Analyze the code changes in the merged PR
  • Search docs repository for relevant Apple Pay/purchase flow documentation
  • Determine if user-facing behavior changed in a way that requires docs updates
  • Update documentation if needed, or explain why no updates are necessary

Analysis Complete

Changes in PR #2460:

  • Modified packages/keychain/src/components/purchasenew/pending/bridge.tsx
  • For Apple Pay payments, two intermediate transaction confirmation steps are now hidden:
    • "Bridging to Starknet" step
    • "Purchasing on Starknet" step
  • Only the initial "Coinbase confirmation" step is now shown
  • Code includes TODO comment indicating this is a temporary change

Documentation Review:
Reviewed docs-repo/src/pages/controller/coinbase-onramp.md which documents the Coinbase onramp integration and user flows.

Decision: No Documentation Updates Required

Following the strict documentation rules provided:

  1. DEFAULT TO NO CHANGES: This is an internal UI implementation detail that temporarily hides intermediate transaction status steps. The core user flow remains unchanged - users still complete purchases successfully.

  2. Temporary Nature: The code explicitly marks this as "TODO: temporarily hidden for apple-pay" - temporary implementation details should not be documented.

  3. No API/Configuration Changes: The change doesn't affect:

    • Developer-facing APIs
    • Configuration options
    • Integration code
    • Feature availability
    • User requirements or capabilities

  4. Documentation Already Accurate: The existing documentation at lines 68-78 correctly describes the high-level user experience flow, which is still valid. Users still go through the same steps conceptually; they just see less granular status updates in the UI temporarily.

The documentation describes what users can do (purchase crypto via Apple Pay), not the specific intermediate UI states shown during processing. This internal UI refinement doesn't change that capability or the integration steps for developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@broody