fix: improve EVM wallet detection and provider discovery#2468
Merged
Conversation
Viewport-based detection incorrectly flagged popup windows as mobile, preventing EVM wallet detection in the forcePopup auth flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove isMobile() gate from wallet detection — extensions don't exist on mobile so the check was redundant and broke popup windows. Re-scan EIP-6963 providers on each isAvailable() call to handle late announcements. Add getFallbackProvider() hook for subclasses: MetaMask falls back to window.ethereum, Phantom EVM to window.phantom.ethereum. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Each EthereumWalletBase instance was creating its own mipd store, causing late provider announcements (e.g. Phantom EVM) to be missed. A shared store captures all announcements in one place. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Claude finished @broody's task —— View job Analyzing PR changes for documentation impact
Analysis ResultNo documentation updates required. This PR contains internal implementation improvements that do not affect the user-facing API or documented behavior: What changed (internally):
Why no docs updates are needed:
Existing documentation coverage: Following the direct prompt rule #1: DEFAULT TO NO CHANGES - internal refactors and bug fixes do not require documentation updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAvailable()checksTest plan
🤖 Generated with Claude Code