Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #514 +/- ##
==========================================
+ Coverage 67.98% 68.13% +0.14%
==========================================
Files 63 64 +1
Lines 3089 3116 +27
Branches 574 577 +3
==========================================
+ Hits 2100 2123 +23
- Misses 805 809 +4
Partials 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
…atibility Co-authored-by: hsluoyz <3787410+hsluoyz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issues with eval() function implementation in jcasbin
Block AviatorScript-specific syntax in eval() for cross-platform compatibility
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #464
jCasbin's
eval()function exposes AviatorScript namespace methods (seq.list(),string.startsWith(),math.sqrt(), etc.) and advanced features (lambda,let,for, etc.) that don't exist in other Casbin implementations, breaking policy portability across Go/Node.js/Python/.NET.Changes
Expression Validator
ExpressionValidatorclass blocks AviatorScript-specific patterns via regex matchingBuiltInFunctions.eval()before executionfalse(no exceptions thrown)Blocked Syntax
seq.*,string.*,math.*lambda,let,fn,for,while,return,if-then-else,->,=>Still Allowed
&&,||,==,!=,<,>,<=,>=,+,-,*,/,!,ing(),keyMatch*(),regexMatch(),ipMatch(),globMatch(),eval()addFunction()Example
Test Coverage
Added
ExpressionValidatorTestwith 10 test methods covering valid/invalid syntax patterns. All 264 existing tests pass.