feat: Port no-policy ABAC feature from Go Casbin #517
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the no-policy ABAC optimization from Go Casbin (#918) that allows matchers to evaluate purely on request attributes without iterating through policies.
Changes
Core enforcement logic: Added regex-based detection to check if matcher references policy tokens (
p_,p2_, etc.). When matcher only uses request attributes (e.g.,r.sub == r.obj.Owner), skip policy iteration and evaluate once.Helper extraction: Created
populateRequestParameters()to consolidate JSON parsing logic across policy and no-policy branches.Validation: Added check to prevent
eval()usage when policies aren't loaded, matching Go Casbin behavior.Example
Pattern detection handles multiple policy types via regex
{pType}\d*_with proper escaping to prevent injection.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.