Open
Conversation
17c3ca8 to
685bf6e
Compare
Contributor
Author
|
@casey how do you feel about this implementation? |
casey
requested changes
Feb 4, 2025
Owner
casey
left a comment
There was a problem hiding this comment.
Just took a first look at this!
I think it's probably not a good idea to try to construct a Name token, when the source was in fact a string literal, and that Alias should be refactored to make the name field a String. If we need a token so we can report error locations, we shoiuld use a Token, and the underlying TokenKind may be a Identifier or a StringLiteral, depending on the source.
You can use Lexer::is_identifier to check if StringLiteral::cooked is a valid identifier. StringLiteral::cooked should be use, since it may contain escape characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #2349