fix formatting of attributes on modules#2734
Open
V1dV1d wants to merge 2 commits intocasey:masterfrom
Open
Conversation
V1dV1d
force-pushed
the
fmt-mod-attributes
branch
from
eda3618 to
e43c0c2
Compare
casey
requested changes
Jun 24, 2025
Owner
casey
left a comment
casey
left a comment
There was a problem hiding this comment.
Modules may have multiple groups, so we should print them all, not just the first. See comment!
V1dV1d
force-pushed
the
fmt-mod-attributes
branch
from
e43c0c2 to
cf34244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, love the tool and that it comes with a formatter built in :)
However, I found that while setting attributes on
modstatements works perfectly, the formatter apparently is not aware of this feature.I just added a fairly naive implementation adding the two currently allowed attributes to the module
impl Display. Also comes with a simple integration test.I know that the formatter is an unstable feature and not the highest priority, but I personally use it and would love to see this fixed. Let me know if any of this needs fixing up, I'll happily do it :)