Add flag to measure recipe execution time#3099
Open
GeorgeLS wants to merge 2 commits intocasey:masterfrom
Open
Add flag to measure recipe execution time#3099GeorgeLS wants to merge 2 commits intocasey:masterfrom
GeorgeLS wants to merge 2 commits intocasey:masterfrom
Conversation
Signed-off-by: George Liontos <georgeliontos98@gmail.com>
casey
requested changes
Mar 30, 2026
Owner
casey
left a comment
casey
left a comment
There was a problem hiding this comment.
See comments! There will be conflicts when rebasing, but the changes to the completion files won't be needed.
| .arg( | ||
| Arg::new(arg::TIME) | ||
| .action(ArgAction::SetTrue) | ||
| .short('t') |
Owner
There was a problem hiding this comment.
I would remove the short flag. They're a scarce resource, so I try to allocate them in response to popular demand.
Suggested change
| .short('t') |
| case "${cmd}" in | ||
| just) | ||
| opts="-E -n -g -f -q -u -v -d -c -e -l -s -h -V --alias-style --ceiling --check --chooser --clear-shell-args --color --command-color --cygpath --dotenv-filename --dotenv-path --dry-run --dump-format --explain --global-justfile --highlight --justfile --list-heading --list-prefix --list-submodules --group --no-aliases --no-deps --no-dotenv --no-highlight --one --quiet --allow-missing --set --shell --shell-arg --shell-command --tempdir --timestamp --timestamp-format --unsorted --unstable --verbose --working-directory --yes --changelog --choose --command --completions --dump --edit --evaluate --fmt --groups --init --json --list --man --request --show --summary --usage --variables --help --version [ARGUMENTS]..." | ||
| opts="-E -n -g -f -q -t -u -v -d -c -e -l -s -h -V --alias-style --ceiling --check --chooser --clear-shell-args --color --command-color --cygpath --dotenv-filename --dotenv-path --dry-run --dump-format --explain --global-justfile --highlight --justfile --list-heading --list-prefix --list-submodules --no-aliases --no-deps --no-dotenv --no-highlight --one --quiet --allow-missing --set --shell --shell-arg --shell-command --tempdir --time --timestamp --timestamp-format --unsorted --unstable --verbose --working-directory --yes --changelog --choose --command --completions --dump --edit --evaluate --fmt --groups --init --list --man --request --show --summary --usage --variables --help --version [ARGUMENTS]..." |
Owner
There was a problem hiding this comment.
The completion scripts are now dynamically generated by calling into the binary, so this diff will go away when your rebase.
| } | ||
| } | ||
|
|
||
| fn print_elapsed_recipe_time( |
|
|
||
| eprint!("{prefix}{recipe_name}"); | ||
|
|
||
| for arg in recipe_args { |
Owner
There was a problem hiding this comment.
I'm not sure about including recipe args, they can be quite long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of this PR, I have added a new simple feature for printing elapsed time of recipes.
The output format is really simple:
<materialized_recipe> (<elapsed_time>).Here's an example of two recipes and the output for those:
Recipe 1:
Output:
Recipe 2:
Invocation:
Output:
The duration is reported as soon as the recipe finishes.
Please note that if you have recursive recipes where you basically invoke
justinside the recipe, the time reporting won't be propagated to the recursive invocation. If you want to measure the inner-invoked recipe, just pass-t/--timeto the innerjustinvocation.