Quote activation exports and paths for space-containing roots #545
+97
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Disclaimer: I'm not a go dev but hit this bug today and figured I'd throw up a PR with the assistance of AI. Feel free to mock and/or shame me 😂
Summary
evalis safe when environment roots contain spacesHow This Was Discovered
This surfaced while running Hermit from a CodexMonitor-managed git worktree. CodexMonitor stores worktrees under:
~/Library/Application Support/com.dimillian.codexmonitor/worktrees/...Because
Application Supportcontains a space,source bin/activate-hermitfailed whenhermit activateemitted unquotedexportvalues. Shellevalsplit those values, causing activation errors in zsh/bash.Testing
go test ./...go test -tags=integration ./integration -run 'TestIntegration/ActivationWorksWhenPathContainsSpaces' -count=1This response was drafted with AI assistance.