Use correct elements configuration for GRADLE_PLUGIN_API_VERSION_ATTR…#542
Open
hfhbd wants to merge 4 commits intocashapp:trunkfrom
Open
Use correct elements configuration for GRADLE_PLUGIN_API_VERSION_ATTR…#542hfhbd wants to merge 4 commits intocashapp:trunkfrom
hfhbd wants to merge 4 commits intocashapp:trunkfrom
Conversation
1 task
Contributor
Author
|
Well, we should just use both, runtime for, well, runtime usage (gradle users) and api for plugin authors building a plugin on top of licensee. |
JakeWharton
approved these changes
Jan 13, 2026
Co-authored-by: Jake Wharton <github@jakewharton.com>
Contributor
Author
|
But I found another bug: We use JVM 25 to run the tests. Gradle 8.12 does not support this new JVM. I created a new Test target to use the jvm toolchain feature (for tests) only. |
JakeWharton
reviewed
Feb 12, 2026
| "Plugin app.cash.licensee:licensee-gradle-plugin", | ||
| ) | ||
| assertThat(result.output).contains( | ||
| "requires at least Gradle 9.0. This build uses Gradle 8.9", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "requires at least Gradle 9.0. This build uses Gradle 8.9", | |
| "requires at least Gradle 9.0. This build uses Gradle $gradleVersion", |
Based on my previous comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…IBUTE
CHANGELOG.md's "Unreleased" section has been updated, if applicable.