Support ignoring dependencies by regex#574
Open
Goooler wants to merge 3 commits intocashapp:trunkfrom
Open
Conversation
JakeWharton
approved these changes
Mar 22, 2026
| unusedCoordinates -= id.group to id.module | ||
| } | ||
| ?: config.ignoredRegexes.entries | ||
| .find { (regex, _) -> regex.toRegex().matches("${id.group}:${id.module}") } |
Collaborator
There was a problem hiding this comment.
Can we compile the regex earlier? Such as when it goes into the map so it's only done once?
Also can the string formatting operation be hoisted outside the find loop so it's only done once?
Co-authored-by: Jake Wharton <github@jakewharton.com>
Goooler
force-pushed
the
ignore-deps-by-regex
branch
from
e163261 to
242a360
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.