Extract SPDX library parsing to a 3rd party library#82
Open
klu2 wants to merge 1 commit intocashapp:trunkfrom
Open
Extract SPDX library parsing to a 3rd party library#82klu2 wants to merge 1 commit intocashapp:trunkfrom
klu2 wants to merge 1 commit intocashapp:trunkfrom
Conversation
Collaborator
|
Thanks for writing this up and the work. I will evaluate it soon. Been busy at work / on vacation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes SPDX parsing from this code-base and replaces it with https://github.com/cloudflightio/spdx-catalog. In order to be fully compatible here, I've adapted the spdx-catalog as follows:
Also updated to SPDX catalog to version 3.16 (3.12 was used previously), and you don't need to update that manually any more.
I've spent quite some time to exactly take over the logic from your plugin in order to be able to join forces here, I hope you like it