Skip to content

Commit 8934a49

Browse files
fix: fix live reload long polling
The etag was not being sent previously which could result in the browser displaying a 503 on reload GitOrigin-RevId: 0cd6a40861693e96d9219baa2fe70230f3fe8e4f
1 parent eb48275 commit 8934a49

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

misk-tailwind/src/main/resources/web/static/js/refresh_dev.js

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,21 +13,22 @@
1313
try {
1414
let response = await fetch(POLL_ENDPOINT, {
1515
method: 'GET',
16+
headers : {
17+
'If-None-Match': reloadMarker
18+
}
1619
});
1720

18-
let nextReloadMarker = await response.text();
19-
20-
if (!!reloadMarker && reloadMarker !== nextReloadMarker) {
21-
console.log('Server has restarted. Reloading page...');
22-
window.location.reload();
23-
} else {
24-
if (isServerDown) {
25-
console.log('Server connection restored.');
26-
isServerDown = false;
27-
}
21+
let nextReloadMarker = response.headers.get('Etag');
22+
if (reloadMarker == null) {
2823
reloadMarker = nextReloadMarker;
29-
checkServerStatus();
24+
} else if (reloadMarker !== nextReloadMarker && nextReloadMarker != null) {
25+
console.log('Server has restarted. Reloading page... ' + reloadMarker + ' -> ' + nextReloadMarker);
26+
window.location.reload();
27+
} else if (isServerDown) {
28+
console.log('Server connection restored.');
29+
isServerDown = false;
3030
}
31+
checkServerStatus();
3132
} catch (error) {
3233
if (!isServerDown) {
3334
console.log('Server connection lost. Waiting for it to come back...');

0 commit comments

Comments
 (0)