Move detectMaxPercentDifferenceDefault method to Paparazzi.kt#2261
Open
nishatoma wants to merge 2 commits intocashapp:masterfrom
Open
Move detectMaxPercentDifferenceDefault method to Paparazzi.kt#2261nishatoma wants to merge 2 commits intocashapp:masterfrom
nishatoma wants to merge 2 commits intocashapp:masterfrom
Conversation
geoff-powell
reviewed
Feb 9, 2026
| } | ||
| } | ||
|
|
||
| public object PaparazziUtils { |
Contributor
There was a problem hiding this comment.
nit: this seems unnecessary to wrap this public fun in an object. Can we just make it class level?
Contributor
Author
There was a problem hiding this comment.
Oh okay, did you mean something like this?
public fun detectMaxPercentDifferenceDefault(): Double =
System.getProperty("app.cash.paparazzi.maxPercentDifferenceDefault")?.toDoubleOrNull() ?: 0.01
It would be an instance method within Paparazzi() is that what you meant? If so, it would not be usable anymore as is on lines 37 and 56 within the constructor.
Or do you mean like a top-level function within Paparazzi.kt file itself?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! As part of feedback from here:
https://github.com/cashapp/paparazzi/pull/2203/changes/BASE..82b4fe2b566ffb055ea434af9b65e2c46f5c5ea1#diff-2c10da07633a221584f8c9dd4d75419da14f458fbc5d0eed23cba5f49a530273R44
This is a follow-up PR that moves the
detectMaxPercentDifferenceDefaulttoPaparazzi.kt.@jrodbx let me know if you have any additional feedback on that.