WIP: Compile dependencies from node_modules#732
Conversation
|
Seems like a great first step. Do you want feedback on the individual TODOs? |
I would gladly take any feedback you have on TODOs! Quite a few are just notes to myself on what needs to be improved in the next round of changes so don't stress about it if you like the general direction this PR is going. |
swankjesse
left a comment
swankjesse
left a comment
There was a problem hiding this comment.
Yeah, this is really cool and something we certainly need. Please proceed !
|
After some research & experimentation, I think we’re gonna try to support a WASM-based future for this project. That means anything we build to better support NPM & JS ecosystem is gonna have a limited lifespan. |
|
Is this still active ? Couldn't resist asking, if yes, any eta on that ? |
4 participants
Resolves #725.
While this all seems to work, it still feels very much like a hack to me as I haven't explored a lot of edge cases. However, I wanted to open a draft PR early just to make sure this is the right approach or if there are other ideas. If you are comfortable with this approach I can start to clean things up and add some test cases.
I was able to get the trivia sample working with passing an
Instantas a game parameter. However I switched to the world-clock sample for the PR since it was a more natural fit; it compiles but I haven't tested it for real yet.