Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a major dependency migration from Pydantic v1 to Pydantic v2, updating package metadata and modernizing the codebase to support Python 3.9+.
Changes:
- Migrated from Pydantic v1 to v2 (changing version from
^1.10.5, <2to2.11.7) - Updated minimum Python version from 3.7 to 3.9
- Replaced Pydantic v1 configuration patterns with v2
model_configdictionaries across all model files - Updated package version and metadata in setup.py and pyproject.toml
Reviewed changes
Copilot reviewed 298 out of 553 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updated package name, version, Python requirement, and Pydantic dependency to v2 |
| pyproject.toml | Updated Python version requirement and Pydantic dependency to v2 |
| configuration.py | Updated SDK package version string |
| cashfree_pg/models/*.py | Migrated all model files to Pydantic v2 syntax (Config class to model_config, validator to field_validator, etc.) |
| test/*.py | Removed extra blank lines in test file headers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| NAME = "cashfree-pg" | ||
| VERSION = "1.0.0" |
There was a problem hiding this comment.
Package name changed from 'cashfree_pg' to 'cashfree-pg' and version reset to '1.0.0'. This is a breaking change that will prevent users from upgrading as it appears to be a completely different package. The version should align with the existing version sequence (e.g., '5.0.0') and the package name should remain 'cashfree_pg' unless there's a deliberate rebranding.
| NAME = "cashfree-pg" | |
| VERSION = "1.0.0" | |
| NAME = "cashfree_pg" | |
| VERSION = "5.0.0" |
| author="Cashfree Payments", | ||
| author_email="developers@cashfree.com", | ||
| url="https://cashfree.com", | ||
| url="", |
There was a problem hiding this comment.
The package URL has been removed. This field should contain a valid URL pointing to the project repository or documentation to help users find more information about the package.
| url="", | |
| url="https://github.com/cashfree/cashfree-pg-sdk-python", |
Raising PR to github