Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the cashfree_pg Python SDK to version 5.0.4, migrating from Pydantic v1 to v2 and updating the Python version requirement.
Changes:
- Upgraded Pydantic from v1 (^1.10.24) to v2 (2.11.7)
- Updated minimum Python version from 3.7 to 3.9
- Migrated all model classes to use Pydantic v2 syntax and patterns
- Updated OpenAPI generator version from 7.0.0 to 7.18.0
Reviewed changes
Copilot reviewed 298 out of 553 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updated VERSION to "1.0.0", PYTHON_REQUIRES to ">=3.9", and pydantic dependency to ">=2.11.7" |
| pyproject.toml | Updated version to "1.0.0", python requirement to "^3.9", and pydantic to "2.11.7" |
| configuration.py | Updated SDK Package Version string to "4.5.1" |
| cashfree_pg/rest.py | Removed blank line formatting |
| cashfree_pg/models/*.py | Migrated all model files to Pydantic v2: updated Config class to model_config dict, changed Field syntax, replaced @validator with @field_validator, updated type annotations, and added model_rebuild() calls |
| test/*.py | Removed blank line formatting from test files |
| .openapi-generator/VERSION | Updated OpenAPI generator version from 7.0.0 to 7.18.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # http://pypi.python.org/pypi/setuptools | ||
| NAME = "cashfree_pg" | ||
| VERSION = "4.5.1" | ||
| VERSION = "1.0.0" |
There was a problem hiding this comment.
Version number inconsistency detected. The PR title indicates version '5.0.4', the configuration.py shows '4.5.1', but setup.py and pyproject.toml both specify '1.0.0'. These version numbers should be aligned across all files to avoid confusion and deployment issues.
Suggested change
| VERSION = "1.0.0" | |
| VERSION = "5.0.4" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raising PR to github