Conversation
AngusP
reviewed
Aug 31, 2023
| # run asynchronously if blocking is False | ||
| if not blocking: | ||
| asyncio.create_task(ledger.melt(payload.proofs, payload.pr, payload.outputs)) | ||
| resp = GetMeltResponse(paid=False, preimage=None, change=None) |
Contributor
There was a problem hiding this comment.
Should probably return HTTP 202 Accepted?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of an async payment flow. Makes use of previous changes to NUT-07: add new field
pending.Closes #244
Changes
blocking=Falseto thePOST /meltendpoint which makes it return immediately and pay the invoice in the background.Todo
store_lightning_invoiceonly stores the invoice after payment, should store before and update later