add depracation warnings for remaining deploy-related subcommands

Author: wojcik91

src/deploy/make.rs

@@ -8,11 +8,20 @@ use crate::{command::ClientCommand, common, Success};
 
 pub struct MakeDeploy;
 
+static DEPRECATION_WARNING: &str = r#"
+#################################### WARNING ####################################
+#                                                                               #
+#       make-deploy subcommand is deprecated in favor of make-transaction       #
+#                    and will be removed in a future release                    #
+#                                                                               #
+#################################################################################
+"#;
+
 #[async_trait]
 impl ClientCommand for MakeDeploy {
     const NAME: &'static str = "make-deploy";
     const ABOUT: &'static str =
-        "Create a deploy and output it to a file or stdout. As a file, the deploy can subsequently \
+        "[DEPRECATED: use `make-transaction` instead] Create a deploy and output it to a file or stdout. As a file, the deploy can subsequently \
         be signed by other parties using the 'sign-deploy' subcommand and then sent to the network \
         for execution using the 'send-deploy' subcommand";
 
@@ -32,6 +41,9 @@ impl ClientCommand for MakeDeploy {
     }
 
     async fn run(matches: &ArgMatches) -> Result<Success, CliError> {
+        // show deprecation warning for each use of `put-deploy` subcommand
+        println!("{DEPRECATION_WARNING}");
+
         creation_common::show_simple_arg_examples_and_exit_if_required(matches);
         creation_common::show_json_args_examples_and_exit_if_required(matches);
         let gas_price = creation_common::gas_price::get(matches);

src/deploy/send.rs

@@ -9,11 +9,20 @@ use crate::{command::ClientCommand, common, Success};
 
 pub struct SendDeploy;
 
+static DEPRECATION_WARNING: &str = r#"
+#################################### WARNING ####################################
+#                                                                               #
+#       send-deploy subcommand is deprecated in favor of send-transaction       #
+#                    and will be removed in a future release                    #
+#                                                                               #
+#################################################################################
+"#;
+
 #[async_trait]
 impl ClientCommand for SendDeploy {
     const NAME: &'static str = "send-deploy";
     const ABOUT: &'static str =
-        "Read a previously-saved deploy from a file and send it to the network for execution";
+        "[DEPRECATED: use `send-transaction` instead] Read a previously-saved deploy from a file and send it to the network for execution";
 
     fn build(display_order: usize) -> Command {
         Command::new(Self::NAME)
@@ -29,6 +38,9 @@ impl ClientCommand for SendDeploy {
     }
 
     async fn run(matches: &ArgMatches) -> Result<Success, CliError> {
+        // show deprecation warning for each use of `send-deploy` subcommand
+        println!("{DEPRECATION_WARNING}");
+
         let is_speculative_exec = creation_common::speculative_exec::get(matches);
         let maybe_rpc_id = common::rpc_id::get(matches);
         let node_address = common::node_address::get(matches);

src/deploy/sign.rs

@@ -8,11 +8,20 @@ use crate::{command::ClientCommand, common, Success};
 
 pub struct SignDeploy;
 
+static DEPRECATION_WARNING: &str = r#"
+#################################### WARNING ####################################
+#                                                                               #
+#       sign-deploy subcommand is deprecated in favor of sign-transaction       #
+#                    and will be removed in a future release                    #
+#                                                                               #
+#################################################################################
+"#;
+
 #[async_trait]
 impl ClientCommand for SignDeploy {
     const NAME: &'static str = "sign-deploy";
     const ABOUT: &'static str =
-        "Read a previously-saved deploy from a file, cryptographically sign it, and output it to a \
+        "[DEPRECATED: use `sign-transaction` instead] Read a previously-saved deploy from a file, cryptographically sign it, and output it to a \
         file or stdout";
 
     fn build(display_order: usize) -> Command {
@@ -32,6 +41,9 @@ impl ClientCommand for SignDeploy {
     }
 
     async fn run(matches: &ArgMatches) -> Result<Success, CliError> {
+        // show deprecation warning for each use of `sign-deploy` subcommand
+        println!("{DEPRECATION_WARNING}");
+
         let input_path = creation_common::input::get(matches);
         let secret_key = common::secret_key::get(matches).unwrap_or_default();
         let maybe_output_path = creation_common::output::get(matches).unwrap_or_default();