add deprecation warning for public input/output deploy-related functions

Author: wojcik91

lib/cli/deploy.rs

@@ -53,6 +53,7 @@ pub async fn speculative_put_deploy(
     let rpc_id = parse::rpc_id(maybe_rpc_id);
     let verbosity = parse::verbosity(verbosity_level);
     let deploy = with_payment_and_session(deploy_params, payment_params, session_params, false)?;
+    #[allow(deprecated)]
     crate::speculative_exec(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)
@@ -79,6 +80,7 @@ pub fn make_deploy(
     #[cfg(feature = "std-fs-io")]
     {
         let output = parse::output_kind(maybe_output_path, force);
+        #[allow(deprecated)]
         crate::output_deploy(output, &deploy).map_err(CliError::from)?;
     }
     Ok(deploy)
@@ -100,6 +102,7 @@ pub fn sign_deploy_file(
 ) -> Result<(), CliError> {
     let secret_key = parse::secret_key_from_file(secret_key_path)?;
     let output = parse::output_kind(maybe_output_path, force);
+    #[allow(deprecated)]
     crate::sign_deploy_file(input_path, &secret_key, output).map_err(CliError::from)
 }
 
@@ -115,6 +118,7 @@ pub async fn send_deploy_file(
 ) -> Result<SuccessResponse<PutDeployResult>, CliError> {
     let rpc_id = parse::rpc_id(maybe_rpc_id);
     let verbosity = parse::verbosity(verbosity_level);
+    #[allow(deprecated)]
     let deploy = crate::read_deploy_file(input_path)?;
     #[allow(deprecated)]
     crate::put_deploy(rpc_id, node_address, verbosity, deploy)
@@ -134,7 +138,9 @@ pub async fn speculative_send_deploy_file(
 ) -> Result<SuccessResponse<SpeculativeExecResult>, CliError> {
     let rpc_id = parse::rpc_id(maybe_rpc_id);
     let verbosity = parse::verbosity(verbosity_level);
+    #[allow(deprecated)]
     let deploy = crate::read_deploy_file(input_path)?;
+    #[allow(deprecated)]
     crate::speculative_exec(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)
@@ -211,6 +217,7 @@ pub async fn speculative_transfer(
         payment_params,
         false,
     )?;
+    #[allow(deprecated)]
     crate::speculative_exec(rpc_id, node_address, verbosity, deploy)
         .await
         .map_err(CliError::from)
@@ -248,6 +255,7 @@ pub fn make_transfer(
     #[cfg(feature = "std-fs-io")]
     {
         let output = parse::output_kind(maybe_output_path, force);
+        #[allow(deprecated)]
         crate::output_deploy(output, &deploy).map_err(CliError::from)?;
     }
     Ok(deploy)

lib/cli/tests.rs

@@ -208,10 +208,13 @@ fn should_sign_deploy() {
     let tempdir = tempfile::tempdir().unwrap();
     let path = tempdir.path().join("deploy.json");
 
+    #[allow(deprecated)]
     crate::output_deploy(OutputKind::file(&path, false), &deploy).unwrap();
 
     let secret_key = SecretKey::generate_ed25519().unwrap();
+    #[allow(deprecated)]
     crate::sign_deploy_file(&path, &secret_key, OutputKind::file(&path, true)).unwrap();
+    #[allow(deprecated)]
     let signed_deploy = crate::read_deploy_file(&path).unwrap();
 
     assert_eq!(

lib/lib.rs

@@ -170,6 +170,7 @@ pub async fn put_transaction(
 /// Sends a JSON-RPC `speculative_exec` request to the specified node.
 ///
 /// For details of the parameters, see [the module docs](crate#common-parameters).
+#[deprecated(since = "3.0.0", note = "use `speculative_exec_txn` instead")]
 pub async fn speculative_exec(
     rpc_id: JsonRpcId,
     node_address: &str,
@@ -211,6 +212,7 @@ pub async fn speculative_exec_txn(
 ///
 /// `output` specifies the output file and corresponding overwrite behaviour, or if
 /// `OutputKind::Stdout`, causes the `Deploy` to be printed `stdout`.
+#[deprecated(since = "3.0.0", note = "use `output_transaction` instead")]
 #[cfg(any(feature = "std-fs-io", test))]
 pub fn output_deploy(output: OutputKind, deploy: &Deploy) -> Result<(), Error> {
     write_deploy(deploy, output.get()?)?;
@@ -232,6 +234,7 @@ pub fn output_transaction(output: OutputKind, transaction: &Transaction) -> Resu
 }
 
 /// Reads a previously-saved [`Deploy`] from a file.
+#[deprecated(since = "3.0.0", note = "use `read_transaction_file` instead")]
 #[cfg(any(feature = "std-fs-io", test))]
 pub fn read_deploy_file<P: AsRef<Path>>(deploy_path: P) -> Result<Deploy, Error> {
     let input = fs::read(deploy_path.as_ref()).map_err(|error| Error::IoError {
@@ -265,12 +268,14 @@ pub fn read_transaction_file<P: AsRef<Path>>(transaction_path: P) -> Result<Tran
 ///
 /// The same path can be specified for input and output, and if the operation fails, the original
 /// input file will be left unmodified.
+#[deprecated(since = "3.0.0", note = "use `sign_transaction_file` instead")]
 #[cfg(any(feature = "std-fs-io", test))]
 pub fn sign_deploy_file<P: AsRef<Path>>(
     input_path: P,
     secret_key: &SecretKey,
     output: OutputKind,
 ) -> Result<(), Error> {
+    #[allow(deprecated)]
     let mut deploy = read_deploy_file(input_path)?;
 
     deploy.sign(secret_key);