Interaction with Casper smart-contract source code verification service by moubctez · Pull Request #144 · casper-ecosystem/casper-client-rs

moubctez · 2024-04-05T08:20:48Z

Allow interaction with Source Code Verification Service.

Check https://github.com/teonite/Casper-SCVS-Verificator for details.

zacshowa

Largely looks good.

I would also like to see some discussion surrounding the retry logic in this code.

There are some style nits to address, and this change should be added to the change log entry corresponding to the release that you want this code to go out in.

lib/verification.rs

lib/verification_types.rs

lib/verification.rs

lib/lib.rs

src/verify_contract.rs

zacshowa

I have one additional suggestion for the about message for the command, Other than that this looks good to me.

Co-authored-by: Zach Showalter <zacshowa@gmail.com>

moubctez · 2024-04-11T18:14:53Z

I have one additional suggestion for the about message for the command, Other than that this looks good to me.

Good suggestion. I've applied it.

zacshowa · 2024-04-18T15:52:09Z

Just wanted to keep you up to date on this PR. Currently it's failing Cargo audit because of a dependency having a security issue,
This is an issue that is currently being fixed in this PR.

Once that PR merges, you should be able to cherry pick the changes into this PR and make it ready to merge.

moubctez · 2024-04-19T08:47:18Z

Just wanted to keep you up to date on this PR. Currently it's failing Cargo audit because of a dependency having a security issue, This is an issue that is currently being fixed in this PR.

Once that PR merges, you should be able to cherry pick the changes into this PR and make it ready to merge.

I have upgraded "vergen" to v8 to resolve the issue.

…to contract-verification-command

lib/verification.rs

Cargo.toml

lib/verification.rs

build.rs

moubctez · 2024-06-24T08:18:56Z

@gRoussac Now build.rs is the correct one. I had ancient history in dev. My fault.

gRoussac · 2024-06-24T15:31:27Z

@moubctez You build is failing tokio is an optional dep so it needs to be specified when used
try to add that arround

#[cfg(feature = "tokio")]

44fef2d#file-lib-verification-rs-L11

probably an import issue for second error

44fef2d#file-lib-lib-rs-L577

Thanks

… feature. Note that reqwest is not optional and depends on tokio with "net" and "time" features enabled, so there is no additional burden.

Fix CI-CD tokio not optional

gRoussac · 2024-06-28T10:06:20Z

When/if merging please choose, "Squash and merge" thank you

…tem#175 Part of casper-ecosystem#144 Enable CI CD check on feat-track-2.0

devendran-m · 2024-08-07T15:10:03Z

Hi @gRoussac , could we now merge this PR please?

* Add feat-track-node-2.0 to CI * Port from dev to feat-track-2.0 of #149 #175 Part of #144 Enable CI CD check on feat-track-2.0 * clippy/test/build with no default features not yet working * Clippy * Commenting out ci/cd for --no-default-features

kchudy and others added 21 commits December 22, 2023 12:59

Added verify-contract command

2b9d3e7

Added verify contract to lib

b9149a9

Added function for creating archive

f879378

Added arg parsing

d0c6241

Added verificator api client

bf44ebb

Added waiting for verification to finish

a6e6360

Switched to deploy hash

ff261d5

Updated comments

e4c24de

Added getting verification details

ffb53e3

Imploved error handling

4d756f6

Improved logging

104d4cb

Refactored verification function

f07b7ec

Initialized API client

d72f852

Adopt new datatypes; use reqwest

4266492

Cleanup

979ed97

Fix result type

2392104

Fixes and cleanups

4f321b5

Sync structs with verificator

21012c4

More retries

5e43e05

Increase number of retries

5a3af7c

Shorten message

af1c39b

moubctez marked this pull request as ready for review April 5, 2024 08:20

moubctez changed the title ~~Casper smart contract source code verification service~~ Interaction with Casper smart-contract source code verification service Apr 5, 2024

zacshowa suggested changes Apr 9, 2024

View reviewed changes

zacshowa reviewed Apr 9, 2024

View reviewed changes

src/verify_contract.rs Outdated Show resolved Hide resolved

Resolve comments

d9caa43

zacshowa reviewed Apr 10, 2024

View reviewed changes

src/verify_contract.rs Outdated Show resolved Hide resolved

zacshowa approved these changes Apr 10, 2024

View reviewed changes

moubctez and others added 2 commits April 11, 2024 20:11

Update src/verify_contract.rs

3f944b1

Co-authored-by: Zach Showalter <zacshowa@gmail.com>

cargo fmt

ad4bf50

Update vergen to v8. This resolves audit error.

e395eae

Merge branch 'dev' of github.com:casper-ecosystem/casper-client-rs in…

b59f117

…to contract-verification-command

gRoussac requested changes Jun 17, 2024

View reviewed changes

lib/verification.rs Outdated Show resolved Hide resolved

gRoussac reviewed Jun 17, 2024

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

Cargo.toml Outdated Show resolved Hide resolved

lib/verification.rs Show resolved Hide resolved

Resolve pull request comments

537347d

gRoussac requested changes Jun 21, 2024

View reviewed changes

build.rs Show resolved Hide resolved

Restore vergen

96c3013

gRoussac approved these changes Jun 24, 2024

View reviewed changes

gRoussac requested changes Jun 24, 2024

View reviewed changes

build.rs Show resolved Hide resolved

Use correct build.rs

44fef2d

gRoussac approved these changes Jun 24, 2024

View reviewed changes

Adam Ciarciński and others added 4 commits June 26, 2024 21:11

Fix build without default features. Now tokio is required with "time"…

258db32

… feature. Note that reqwest is not optional and depends on tokio with "net" and "time" features enabled, so there is no additional burden.

Fix wasm build

c047567

Fix CI-CD tokio not optional

deaa529

Merge pull request #2 from gRoussac/contract-verification-command

f53e85d

Fix CI-CD tokio not optional

gRoussac added a commit to gRoussac/casper-client-rs that referenced this pull request Jul 17, 2024

Port from dev to feat-track-2.0 of casper-ecosystem#149 casper-ecosys…

f533494

…tem#175 Part of casper-ecosystem#144 Enable CI CD check on feat-track-2.0

gRoussac mentioned this pull request Jul 17, 2024

Remove vergen dep on feat-track-2.0 for cargo audit #185

Merged

gRoussac linked an issue Jul 17, 2024 that may be closed by this pull request

Add Source Code Verification option #187

Open

Conversation

moubctez commented Apr 5, 2024

Uh oh!

zacshowa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zacshowa left a comment

Choose a reason for hiding this comment

Uh oh!

moubctez commented Apr 11, 2024

Uh oh!

zacshowa commented Apr 18, 2024

Uh oh!

moubctez commented Apr 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moubctez commented Jun 24, 2024

Uh oh!

gRoussac commented Jun 24, 2024

Uh oh!

gRoussac commented Jun 28, 2024

Uh oh!

devendran-m commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants