Skip to content

chore(helm): remove kvisor.apiGrpcAddr helper, inline grpcAddr directly#674

Open
0msokolowski0 wants to merge 1 commit intomainfrom
msokolowski.grpcURL
Open

chore(helm): remove kvisor.apiGrpcAddr helper, inline grpcAddr directly#674
0msokolowski0 wants to merge 1 commit intomainfrom
msokolowski.grpcURL

Conversation

@0msokolowski0
Copy link
Contributor

Summary

  • Remove the kvisor.apiGrpcAddr helper introduced in feat(helm): support global.castai overrides (apiURL, grpcURL, clusterID) for umbrella chart #653 — it abstracted global.castai.grpcURL > castai.grpcAddr resolution but the global gRPC URL override is no longer needed
  • Revert agent.yaml and controller.yaml to reference .Values.castai.grpcAddr directly for CASTAI_API_GRPC_ADDR
  • Remove corresponding unit tests for global.castai.grpcURL fallback behavior
  • kvisor.apiURL and global.castai.apiURL support are unaffected

@0msokolowski0 0msokolowski0 marked this pull request as ready for review March 18, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant