Fix DynamicProxyException ("duplicate element") due to DynamicProxy not accounting for outer type names of nested types#692
Merged
stakx merged 5 commits intocastleproject:masterfrom Jan 5, 2026
Conversation
stakx
reviewed
Nov 23, 2025
Member
|
@JelleKerkstra, apologies for the very long delay. I realise it has been more than a year since you submitted this PR. If you're no longer interested in this, that's OK, too. Let me know whether or not you'd like to proceed. |
…implementation names
`string.Concat` can be up to twice as fast as using `StringBuilder`. This change will nearly restore the original performance of that method, with a small penalty due to the added `.IsNested` checks and more precise representation of generic type arguments.
Member
|
@JelleKerkstra, I haven't heard back from you, but I'd like to see this bug fix get merged. Since there was an issue in your proposed code changes with the fast path getting removed from |
DynamicProxyException ("duplicate element") due to DynamicProxy not accounting for outer type names of nested types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the
DynamicProxyExceptionDuplicate element: Castle.DynamicProxy.Generators.MetaMethodwhen generating a proxy that implements the following interfaces due to the nested classes.In the current implementation, only the namespace, type name and method name are considered. In this PR, the declaring type names are also used when generating explicit interface implementations due to matching method names.