Remove some unnecessary code in member and type emitters#713
Merged
stakx merged 9 commits intocastleproject:masterfrom Dec 21, 2025
Merged
Remove some unnecessary code in member and type emitters#713stakx merged 9 commits intocastleproject:masterfrom
stakx merged 9 commits intocastleproject:masterfrom
Conversation
If `EnsureValidCodeBlock` needs to be called before `Generate`, why not simply delegate that responsibility to the `Generate` implementations themselves?
... as it is not applicable to all member types.
... since DynamicProxy does in actual fact not ever generate any types that aren't classes.
stakx
force-pushed
the
refactor/member-and-type-emitters
branch
from
73d58ed to
0efd7a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.