-
-
Notifications
You must be signed in to change notification settings - Fork 163
Run specs in parallel, speed up CI, fix concurrency bugs in specs and code #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
apiology
wants to merge
1,513
commits into
castwide:v0.59
Choose a base branch
from
apiology:parallel_rspec
base: v0.59
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing_merge Or support in flow sensitive typing merge
Add a regression test and fix for self type resolution issue found on a future branch
This causes duplicate logging on standard libraries, many of which are esoteric (e.g., "cgi-escaping"). The current method as of the 2025-01-06 branch would result in each stdlib library being cached individually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rspec to use more than one CPU. Really useful on modern dev machines, and also useful in CI, where the default runner size has two CPUs.
See https://github.com/apiology/solargraph/pull/27/changes for a more useful diff
To do:
Reduces the actual testing time in CI to about a minute using our small workers:
There are also a few fixes here:
Includes for mergability:
Includes this build fix:
Includes the fix for this bug, which parallel running seems to trigger (more often?):
Includes to show combined effect:
Includes transitively: