Skip to content

Work around erb bundle problem with RBS pre-release #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apiology wants to merge 3 commits into
base: v0.59
Choose a base branch
from
Open

Work around erb bundle problem with RBS pre-release #1168

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92a677f
Reproduce build problem with RBS pre-release
apiology Jan 31, 2026
3725fa9
Stop hard-coding bundler version
apiology Jan 31, 2026
d68c906
Use bundler preferred by setup-ruby step
apiology Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions .github/workflows/rspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby-version }}
# see https://github.com/castwide/solargraph/actions/runs/19391419903/job/55485410493?pr=1119
#
# match version in Gemfile.lock and use same version below
bundler: 2.5.23
bundler-cache: false
bundler-cache: true
- name: Set rbs version
run: echo "gem 'rbs', '${{ matrix.rbs-version }}'" >> .Gemfile
# /home/runner/.rubies/ruby-head/lib/ruby/gems/3.5.0+2/gems/rbs-3.9.4/lib/rbs.rb:11:
Expand All @@ -83,9 +79,8 @@ jobs:
# starting from Ruby 3.6.0
- name: Work around legacy rbs deprecation on ruby > 3.4
run: echo "gem 'tsort'" >> .Gemfile
- name: Install gems
- name: Update gems
run: |
bundle _2.5.23_ install
bundle update rbs # use latest available for this Ruby version
- name: Update types
run: bundle exec rbs collection update
Expand All @@ -103,13 +98,7 @@ jobs:
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.4'
# see https://github.com/castwide/solargraph/actions/runs/19391419903/job/55485410493?pr=1119
#
# match version in Gemfile.lock and use same version below
bundler: 2.5.23
bundler-cache: false
- name: Install gems
run: bundle install
bundler-cache: true
- name: Update types
run: bundle exec rbs collection update
- name: Run tests
Expand Down
Loading