Skip to content

Comments

feat: add lua binding for mtype_id#6471

Merged
RoyalFox2140 merged 9 commits intocataclysmbn:mainfrom
NappingOcean:add-lua-binding-for-mtype
May 3, 2025
Merged

feat: add lua binding for mtype_id#6471
RoyalFox2140 merged 9 commits intocataclysmbn:mainfrom
NappingOcean:add-lua-binding-for-mtype

Conversation

@NappingOcean
Copy link
Contributor

@NappingOcean NappingOcean commented May 1, 2025

Purpose of change (The Why)

mtype_id would make lua more useful! Such as spawning monster instantly, making a corpse not human but other monster, or ugh, getting monster id from corpse. It might be useful on sometime or later....

Describe the solution (The How)

Add new binding for mtype_id with following guide

Describe alternatives you've considered

Testing

image

Additional context

Checklist

Mandatory

@github-actions github-actions bot added docs PRs releated to docs page src changes related to source code. labels May 1, 2025
@autofix-ci
Copy link
Contributor

autofix-ci bot commented May 1, 2025

Autofix has formatted code style violation in this PR.

I edit commits locally (e.g: git, github desktop) and want to keep autofix
  1. Run git pull. this will merge the automated commit into your local copy of the PR branch.
  2. Continue working.
I do not want the automated commit
  1. Format your code locally, then commit it.
  2. Run git push --force to force push your branch. This will overwrite the automated commit on remote with your local one.
  3. Continue working.

If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT.

@scarf005 scarf005 changed the title Add lua binding for mtype feat: Add lua binding for mtype May 1, 2025
@scarf005 scarf005 changed the title feat: Add lua binding for mtype feat: add lua binding for mtype_id May 1, 2025
@NappingOcean NappingOcean changed the title feat: add lua binding for mtype_id feat: Add lua binding for mtype_id May 1, 2025
@NappingOcean NappingOcean changed the title feat: Add lua binding for mtype_id feat: add lua binding for mtype_id May 1, 2025
@NappingOcean
Copy link
Contributor Author

stupid me

@github-actions github-actions bot added translation JSON related to game datas in JSON format. labels May 2, 2025
@github-actions github-actions bot removed translation JSON related to game datas in JSON format. labels May 2, 2025
@scarf005 scarf005 self-requested a review May 3, 2025 09:31
@RoyalFox2140 RoyalFox2140 merged commit e7009ef into cataclysmbn:main May 3, 2025
16 checks passed
@NappingOcean NappingOcean deleted the add-lua-binding-for-mtype branch May 3, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs PRs releated to docs page src changes related to source code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants