feat(port): add travel_to_dimension#7691
feat(port): add travel_to_dimension#7691NappingOcean wants to merge 14 commits intocataclysmbn:mainfrom
travel_to_dimension#7691Conversation
Port dimensional travel infrastructure from DDA PR #82924. Enables separate world instances within same save file. Refactored for BN: - Use invalidate_map_cache() instead of invalidate_visibility_cache() - Replace place_vehicle() with direct vehicle placement logic - Implement vehicle cache rebuild with explicit loops - Use current_region_type for dimension-specific region settings - Simplify dimension data serialization (region_type only) Co-authored-by: Blueflowerss <143913900+Blueflowerss@users.noreply.github.com> Co-authored-by: kevingranade <kevin.granade@gmail.com> Co-authored-by: bombasticSlacks <bombasticslacks@users.noreply.github.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
Co-authored-by: scarf <greenscarf005@gmail.com>
|
Still have problems for travelling with a vehicle. Aggghhh |
|
I have thought this issue for a while, and decided to postpone this vehicle issue later. It would be better to implement the main feature first and then implement the rest one by one later. |
AzmodiusX
left a comment
There was a problem hiding this comment.
It compiles and runs.
I verified that the pocket watch works.
It also doesn't work if I use the watch for the dimension I'm in.
I do note the overmap desert just shows "field" for desert tiles, but it seems to not be an error, per se.
Not approval because draft and we need to make decisions.
Didn't happen the first time, but now 2 times in a row. |
Implemented world types Overmap shows name Ported most / all of functionality from pocket dimension part of my dimension PR
Co-authored-by: NappingOcean <129575271+NappingOcean@users.noreply.github.com>
feat: Pocket dimension extension (correct fork)
|
Hey, this got sidelined for a decent amount of time. |
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
|
@AzmodiusX Sorry. I was busy IRL so forgot this. |
Purpose of change (The Why)
We want to go further world. Further and further, even another dimension.
This PR will bring us isekai.
Describe the solution (The How)
Ported over CleverRaven/Cataclysm-DDA#82924
Added
travel_to_dimensionmethod and the tag for region_settings, and implemented forgetting the world you saw and saving the world where we come back after, etc.Describe alternatives you've considered
Screm
Testing
Not yet.
Additional context
I hope that this PR can help sky island project(#7652).
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
portscope to the PR title.Co-Authored-Byin the commit message.docs/folder.lang/bn_extract_json_strings.shscript if it does not support them yet.luascope to the PR title.deno task docs:genso the Lua API documentation is updated.