feat(port): nested crafting categories, UI changes#8059
Open
shmakota wants to merge 9 commits intocataclysmbn:mainfrom
Open
feat(port): nested crafting categories, UI changes#8059shmakota wants to merge 9 commits intocataclysmbn:mainfrom
shmakota wants to merge 9 commits intocataclysmbn:mainfrom
Conversation
ports change CleverRaven/Cataclysm-DDA#59924 needs refined Co-Authored-By: Dillon Matchett <4514073+bombasticSlacks@users.noreply.github.com>
ports CleverRaven/Cataclysm-DDA#59924 and CleverRaven/Cataclysm-DDA#60761, with improvements on top of it Co-Authored-By: Dillon Matchett <4514073+bombasticSlacks@users.noreply.github.com>
ports CleverRaven/Cataclysm-DDA#59924 and CleverRaven/Cataclysm-DDA#60761, with improvements on top of it Co-Authored-By: Dillon Matchett <4514073+bombasticSlacks@users.noreply.github.com>
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
4 tasks
WishDuck
approved these changes
Mar 22, 2026
Collaborator
WishDuck
left a comment
There was a problem hiding this comment.
Compiled and Load tested
All nested recipes are now valid
All nested categories are optional -> for player benifit and in a certain area
I see nothing wrong with the plan
Green Checkymarky
Member
|
maybe #8344 could fix some of the issue |
Collaborator
|
There will probably still be many categorized things that will be outside that system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Continuation of #8059.
The UI can be hard to navigate when there's a ton of recipes. Additionally, the UI can end up unorganized as "fairy sandwich" will not be next to "meat sandwich". As a result, I believe organization could be greatly improved with nested categories.
Describe the solution (The How)
Ports DDA PRs: CleverRaven/Cataclysm-DDA#59924, CleverRaven/Cataclysm-DDA#60761 and CleverRaven/Cataclysm-DDA#60683. Additionally has a few improvements to the UI I made on our end so it feels up to snuff with the rest of the UI.
Changes item cards to show the subcategory of item as well as category now.
This allows for "nested categories" which can be found in the crafting UI under a subcategory. These are used to group similar things in the menu. For example, sandwiches are under "SNACKS" but they're spread out with things like butter and popcorn and such in between them. This allows for better organization and hopefully improved user experience over time as they gain the muscle memory to work with this new system.
Describe alternatives you've considered
Leaving the menu as-is. Although there were concerns with the previous PR about android users suffering more button presses, I think this is an improvement. Additionally we can likely make this toggleable, as it's just a visual grouping thing currently.
Putting all nested recipes under a nested tab. So it would go food > nested > sandwiches, I think this would help organization as it feels weird to make duplicates in the other menus (ham sandwich and fairy sandwich gets moved under snacks, and no longer in meat and junk respectively otherwise)
Testing
Spawn in, go to FOOD > SNACKS > SANDWICHES and craft a sandwich. Favorite the category, notice the entire category properly shows in favorites. Unfavorite it, and favorite a specific item from the category. Notice that it displays on it's own in the favorites menu.
Additional context
showing off a nested category
showing off that it now shows subcategory like category / subcategory
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
portscope to the PR title.Co-Authored-Byin the commit message.docs/folder.lang/bn_extract_json_strings.shscript if it does not support them yet.